WATCH OUT: this changes the binary interface (ABI) for modules,
so e.g. users of g729 codecs need a rebuilt module (but read below).
The new way to write CLI handlers is described in detail in cli.h,
and there are a few converted handlers in cli.c, look for NEW_CLI.
After converting a couple of commands i am convinced that
it is reasonably convenient to use, and it makes it easier to fix the
pending CLI issues.
On passing, note a bug with the current 'complete' architecture:
if a command is a prefix of multiple CLI entries, we miss some
of the possible options. As an example, "core set debug" can
continue with "channel" from one CLI entry, and "off" or "atleast"
from another one.
We address this problem in a separate commit
(when i have figured out a fix, that is).
ABI issues:
I asked Kevin if it was ok to make this change and he said yes.
While it would have been possible to make the change without breaking
the module ABI, the code would have been more convoluted.
I am happy to restore the old ABI (while still being able
to use the "new style" handlers) if there is demand.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@47606 f38db490-d61c-443f-a65b-d21fe96a405b
........
r47558 | file | 2006-11-13 12:38:44 -0500 (Mon, 13 Nov 2006) | 2 lines
Clean up last commit to better conform to standards.
........
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@47559 f38db490-d61c-443f-a65b-d21fe96a405b
and related code rearrangement.
Approved by: oej
This could be made better if we declared
struct sip_pvt *dialpg = pkt->owner;
at the beginning of the function, and use it throughout the function.
I'll let the boss decide :)
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@47539 f38db490-d61c-443f-a65b-d21fe96a405b
simplify __sip_ack() removing a strcmp for looking up packets.
no functional change, only performance, so don't need to merging
to earlier branches now.
Approved By: oej
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@47538 f38db490-d61c-443f-a65b-d21fe96a405b
there is no functional change, so it is not necessary to
bother merging this to 1.4 now.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@47537 f38db490-d61c-443f-a65b-d21fe96a405b
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r47527 | russell | 2006-11-13 00:48:18 -0500 (Mon, 13 Nov 2006) | 5 lines
AC_PROG_SED is included in autoconf 2.60, but apparently it is not included
in 2.59. So, to maintain compatability with 2.59 since it is a small change,
copy this macro into acinclude.m4 and rename it to AST_PROG_SED.
(issue #8345)
........
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@47529 f38db490-d61c-443f-a65b-d21fe96a405b
versions of the format string are identical. Also, since each format is only
used once, get rid of the use of defines all together. (issue #8344, julieng)
In passing, also clean up the formatting a but to get rid of the nesting
without the use of braces, as defined in the coding guidelines.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@47520 f38db490-d61c-443f-a65b-d21fe96a405b
- Keep RTP running during T.38 session
We might improve the code to issue ast_rtp_stop if T.38 re-invite not fails
later on in the code, but I don't see many reasons to.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@47510 f38db490-d61c-443f-a65b-d21fe96a405b
https://origsvn.digium.com/svn/asterisk/branches/1.4
................
r47497 | russell | 2006-11-12 01:23:23 -0500 (Sun, 12 Nov 2006) | 12 lines
Merged revisions 47496 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r47496 | russell | 2006-11-12 01:09:03 -0500 (Sun, 12 Nov 2006) | 4 lines
Only do the check to determine whether the channel calling this function is an
IAX2 channel when getting the IP address using the special argument,
CURRENTCHANNEL. (issue #8341, jcovert)
........
................
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@47498 f38db490-d61c-443f-a65b-d21fe96a405b
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r47494 | russell | 2006-11-11 10:31:08 -0500 (Sat, 11 Nov 2006) | 6 lines
Add the target "menuconfig" as an alias for the "menuselect" target. This is
just a favor to users so that if you accidentally type "make menuconfig"
instead of "make menuselect", it still works.
(inspired by a comment on IRC from wangster calling me an "especially devious
asterisk developer" for having it be menuselect instead of menuconfig. :) )
........
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@47495 f38db490-d61c-443f-a65b-d21fe96a405b
rizzo