Archived
14
0
Fork 0
Commit graph

279 commits

Author SHA1 Message Date
tilghman
6a7394d3c3 Memory leak
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@139707 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-24 16:26:48 +00:00
tilghman
980a351bb3 Eliminate open coding of ast_str
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@139704 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-24 16:23:15 +00:00
seanbright
f0179a2d10 Fix memory leak in cdr_sqlite3_custom.
(closes issue #13304)
Reported by: eliel
Patches:
      sqlite.patch uploaded by eliel (license 64)
      (Slightly modified by me)


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@137933 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-14 18:47:28 +00:00
seanbright
1a0b3cb4c4 If we detect that we are no longer connected, try to reconnect a few times
before giving up.  This relies on the timeout settings in the freetds.conf
file and, unfortunately, on a recent version of FreeTDS (0.82 or newer).

I either need to change the current execs to be non-blocking (which I do
not want to do) or we have to force people to run with the latest and
greatest of FreeTDS.  I'm on the fence...


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@137780 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-14 15:03:03 +00:00
seanbright
cbb6473eba Use the ast_vasprintf macro instead of vasprintf directly.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@137403 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-13 14:22:47 +00:00
seanbright
ff2f832957 Log the userfield CDR variable like the other CDR backends, assuming the
column is actually there.  If it's not, we still log everything else as
before.

(closes issue #13281)
Reported by: falves11


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@137203 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-11 14:25:15 +00:00
tilghman
777979c9d9 Fix runtime symbol error
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@136406 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-07 15:10:53 +00:00
seanbright
4965ac5e36 More from the resolve-shadow-warnings branch. This time the cdr/ directory.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@136300 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-07 00:52:23 +00:00
bbryant
b2c8abebab Fix magic Revision keywords in hashtab.c and change cdr_radius.c to use
the same keyword as the other files (patch by eliel).

(closes issue #13104)
Reported by: eliel
Patches:
      revision.patch uploaded by eliel (license 64)


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@132050 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-18 17:55:41 +00:00
seanbright
745361390b Fix a bug I noticed while doing the previous merge
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@127398 f38db490-d61c-443f-a65b-d21fe96a405b
2008-07-02 14:30:09 +00:00
seanbright
0673fac47e Cast a few more strings to char *, so that we can compile cleanly against
FreeTDS 0.60.  Update the docs to reflect that we can now compile and run
against all modern releases of FreeTDS (0.60 through 0.82)


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@126513 f38db490-d61c-443f-a65b-d21fe96a405b
2008-06-30 11:57:42 +00:00
seanbright
8530e0fda8 This was bogus, need to find a better way.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@126319 f38db490-d61c-443f-a65b-d21fe96a405b
2008-06-29 13:20:01 +00:00
seanbright
76942ba4d3 While we're at it, escape all the columns in our TDS queries as well. Double
quotes seems to be more standard than square brackets (Sybase and SQL Server
both support them).


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@126312 f38db490-d61c-443f-a65b-d21fe96a405b
2008-06-29 13:11:55 +00:00
seanbright
e4e30b0abe Quote column names when inserting CDRs into postgres to avoid conflicts
with reserved words.

(closes issue #12947)
Reported by: panolex


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@126274 f38db490-d61c-443f-a65b-d21fe96a405b
2008-06-29 12:06:46 +00:00
seanbright
13e31ad1ef Merge in changes from my cdr-tds-conversion branch. This changes the internal
implementation from using the volatile libtds, to using the db-lib front end.
The unintended side effect of this is that we support (at least) versions 0.62
through 0.82 of the FreeTDS distribution without any #ifdef ugliness.

(closes issue #12844)
Reported by: jcollie


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@126226 f38db490-d61c-443f-a65b-d21fe96a405b
2008-06-28 21:28:16 +00:00
murf
04118c0c21 This solves a crash in the cdr_tds module on 'stop gracefully', for situations where 'settings' is not set to a pointer
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@123446 f38db490-d61c-443f-a65b-d21fe96a405b
2008-06-17 20:00:36 +00:00
seanbright
d205516f1d Last commit for a bit, minor cleanups and move the lock initialization.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@123076 f38db490-d61c-443f-a65b-d21fe96a405b
2008-06-16 17:33:10 +00:00
seanbright
1e3cc665ed Convert to use stringfields. Still some more work to do on config load/reload.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@123044 f38db490-d61c-443f-a65b-d21fe96a405b
2008-06-16 17:14:11 +00:00
seanbright
bd4312e1a9 Remove some unused variables
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@123041 f38db490-d61c-443f-a65b-d21fe96a405b
2008-06-16 16:29:18 +00:00
seanbright
a6f0a954b6 Coding guidelines stuff only.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@123009 f38db490-d61c-443f-a65b-d21fe96a405b
2008-06-16 15:25:03 +00:00
jpeeler
490730a6b3 Goodbye Zaptel, hello DAHDI. Removes Zaptel driver support with DAHDI. Configuration file and dialplan backwards compatability has been put in place where appropiate. Release announcement to follow.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@122234 f38db490-d61c-443f-a65b-d21fe96a405b
2008-06-12 17:27:55 +00:00
tilghman
f820a7768e Don't unload config on reload, when config has not changed.
(Closes issue #12652)


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@116631 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-15 17:58:22 +00:00
tilghman
7fe8fd8510 Ensure that "calldate" is acceptable for a column name.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@115596 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-10 14:19:41 +00:00
seanbright
72c0111028 Minor logging cleanups
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114314 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-20 14:52:07 +00:00
tilghman
67c7e1e162 Oops, buffer wasn't long enough for query
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114152 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-15 20:51:08 +00:00
tilghman
7fcb99764d If any field is not null, but has no default, then it must be set or the insert will fail.
(Closes issue #12285)


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114090 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-11 23:26:56 +00:00
tilghman
d3c8cbf15a Merged revisions 113874 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r113874 | tilghman | 2008-04-09 13:57:33 -0500 (Wed, 09 Apr 2008) | 4 lines

If the [csv] section does not exist in cdr.conf, then an unload/load sequence
is needed to correct the problem.  Track whether the load succeeded with a
variable, so we can fix this with a simple reload event, instead.

........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@113875 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-09 19:00:40 +00:00
qwell
624520ee1c Merged revisions 110779 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r110779 | qwell | 2008-03-25 17:51:17 -0500 (Tue, 25 Mar 2008) | 6 lines

Make file access in cdr_custom similar to cdr_csv.

Fixes issue #12268.

Patch borrowed from r82344

........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@110780 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-25 22:51:55 +00:00
twilson
9e8ebe6a94 Go through and fix a bunch of places where character strings were being interpreted as format strings. Most of these changes are solely to make compiling with -Wsecurity and -Wformat=2 happy, and were not
actual problems, per se.  I also added format attributes to any printf wrapper functions I found that didn't have them.  -Wsecurity and -Wmissing-format-attribute added to --enable-dev-mode.


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@109447 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-18 15:43:34 +00:00
tilghman
5b1cec965f Convert prepare_and_execute to direct_execute for speed
(closes issue #11935)
 Reported by: falves11
 Patches: 
       20080208__bug11935.diff.txt uploaded by Corydon76 (license 14)
 Tested by: falves11, Corydon76


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@107722 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-11 21:10:45 +00:00
tilghman
48fd5486a8 Whitespace changes only
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@107551 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-11 16:28:03 +00:00
tilghman
712e98b0a0 Convert to use ast_str
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@105411 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-29 23:53:42 +00:00
tilghman
e5122f6dca Permit additional CDR columns to be saved in Postgres. Note that these
changes are backward-compatible, so no changes to UPGRADE.txt are
necessary.
(closes issue #9279)
 Reported by: rottenroddy
 Patches: 
       20080125__bug9279.diff.txt uploaded by Corydon76 (license 14)
 Tested by: Corydon76


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@104101 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-25 23:04:20 +00:00
tilghman
507fd79b11 Change the way the new filter feature works, by allowing it to be a column NOT
logged into the database.  This will allow more granularity of a decision
evaluated in the dialplan, then takes effect when posting the CDR.


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@98987 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-17 00:13:32 +00:00
tilghman
01335bddee Add the "filter" keyword
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@98947 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-15 23:52:11 +00:00
tilghman
69d71a14de Port Nick Gorham's timestamp patch to adaptive_odbc, too
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@98269 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-11 18:35:30 +00:00
tilghman
bcc664ccd5 Commit Nick Gorham's suggestion for timestamp fix
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@98268 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-11 18:30:00 +00:00
tilghman
45f02f8778 Fix problem with timestr going out of scope
(Closes issue #11726, closes issue #11731)


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@97805 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-10 17:38:36 +00:00
rizzo
659205253c remove unnecessary (char *) casts for ast_config_AST_* variables.
There are some left in the .flex files, left to the maintainer...



git-svn-id: http://svn.digium.com/svn/asterisk/trunk@93582 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-18 09:46:18 +00:00
kpfleming
d4e966efcc Merged revisions 93180 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r93180 | kpfleming | 2007-12-16 22:44:51 -0800 (Sun, 16 Dec 2007) | 23 lines

In http://lists.digium.com/pipermail/asterisk-dev/2007-December/031145.html,
rizzo brought up some issues related to the way that the metadata required
for menuselect and the rest of the build system is extracted from the source
files. Since I had a few hours to kill on an airplane today, I decided to
improve this situation... so now the system caches the extracted metadata
and uses it to build the menuselect 'tree' as much as it can. The result
of this is that when a single source file is changed, only the metadata for
that file needs to be extracted again, and the rest is used from the cache
files. I also reduced the number of forked processes required to do the
metadata extraction; it was actually possible to do most of what we needed
in the Makefiles themselves without using any shell scripts at all! On my
laptop, these changes resulted in an 80% decrease in the time required
for the 'menuselect.makeopts' automatic check to occur after editing a single
source file.

While doing this work I also cleaned up a few minor things in the Makefiles,
adding a check for 'awk' to the configure script and changed all remaining
places we use 'grep' or 'awk' to use the ones found by the configure script,
and changed the 'prep_tarball' script to build the menuselect metadata so
that tarballs of Asterisk will include it and won't require the user to
wait while it is extracted after unpacking.


........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@93184 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-17 07:25:35 +00:00
tilghman
958387bc2e Don't use backslash as an escape character, unless it really is an escape character.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@92779 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-13 17:46:04 +00:00
rizzo
aa85540763 Put into Makefile.moddir_rules the common instructions used to
generate loadable and embedded module lists.

Individual Makefiles now are a lot simpler, possibly as simple as this:

    -include $(ASTTOPDIR)/menuselect.makeopts $(ASTTOPDIR)/menuselect.makedeps
    MODULE_PREFIX=cdr_
    all: _all
    include $(ASTTOPDIR)/Makefile.moddir_rules

and also more flexible because in a single directory we can combine
various types of modules (app_, cdr_, func_, ... ) by simply
listing them in the MODULE_PREFIX variable.

The individual Makefiles can also create list of modules to be
excluded by listing them in the variablel MODULE_EXCLUDE (see an
example in channels/Makefile).

With this change it becomes trivial to integrate a directory with
locally created/modified sources into the main build.




git-svn-id: http://svn.digium.com/svn/asterisk/trunk@92082 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-10 03:50:38 +00:00
rizzo
b50ce18fe8 normalize subdirs' Makefile by using ASTTOPDIR and not .. to reference
the top level directory.



git-svn-id: http://svn.digium.com/svn/asterisk/trunk@92022 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-09 21:29:37 +00:00
qwell
21ea51e69a Fix a problem with quoting in sqlite3 cdr module..
Closes issue #11070, patch by seanbright.


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@91598 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-06 21:57:28 +00:00
tilghman
ee6901bb3c Merged revisions 90166,90736,90753 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r90166 | tilghman | 2007-11-29 13:48:10 -0600 (Thu, 29 Nov 2007) | 3 lines

Properly escape cdr->src and cdr->dst and ensure we use thread-safe escaping
(Fixes AST-2007-026)

........
r90736 | tilghman | 2007-12-03 17:23:55 -0600 (Mon, 03 Dec 2007) | 5 lines

If both dbhost and dbsock were not set, a NULL deref could result
Reported by: xrg
Patch by: tilghman
(Closes issue #11387)

........
r90753 | tilghman | 2007-12-03 17:50:51 -0600 (Mon, 03 Dec 2007) | 5 lines

Solaris requires the inclusion of sys/loadavg.h for getloadavg().
Reported by: snuffy
Patch by: snuffy,tilghman
(Closes issue #11430)

........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@91561 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-06 20:52:26 +00:00
tilghman
a17700ba80 Change cdr_manager to use a "CDR" level, rather than the (overcrowded) "call" level.
(Closes issue #11015)


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@91173 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-05 16:46:47 +00:00
rizzo
150b2c22ef remove another set of redundant #include "asterisk/options.h"
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89512 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-21 23:24:55 +00:00
tilghman
1688610395 Make trunk build again
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89468 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-20 23:29:33 +00:00
rizzo
89d8d78652 move asterisk/paths.h outside asterisk.h and into those files
who really need it.



git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89466 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-20 23:16:15 +00:00
rizzo
0cc47e4221 another bunch of include removals (errno.h and asterisk/logger.h)
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89425 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-19 19:09:03 +00:00