There was a subtle logical difference between 1.4 and trunk with regards to how timeouts
were handled. In 1.4, if the absolute timeout were reached on a call, no matter what the return value of ast_spawn_extension was, the pbx would attempt to go to the 'T' extension or hangup otherwise. The rearrangement of this function in trunk made this check only happen in the case that ast_spawn_extension returned 0. If ast_spawn_extension returned 1, then the fact that the timeout expired resulted in a no-op, and would cause an infinite loop to occur in __ast_pbx_run. This change fixes this problem. Now timeouts will behave as they did in 1.4 (closes issue #11550) Reported by: pj Tested by: putnopvut git-svn-id: http://svn.digium.com/svn/asterisk/trunk@113836 f38db490-d61c-443f-a65b-d21fe96a405b
This commit is contained in:
parent
09f79a4f7a
commit
c4bcafc2fe
1 changed files with 6 additions and 2 deletions
|
@ -3592,8 +3592,12 @@ static int __ast_pbx_run(struct ast_channel *c)
|
|||
if (c->_softhangup == AST_SOFTHANGUP_ASYNCGOTO) {
|
||||
c->_softhangup = 0;
|
||||
continue;
|
||||
} else if (c->_softhangup == AST_SOFTHANGUP_TIMEOUT) {
|
||||
/* atimeout, nothing bad */
|
||||
} else if (c->_softhangup == AST_SOFTHANGUP_TIMEOUT && ast_exists_extension(c, c->context, "T", 1, c->cid.cid_num)) {
|
||||
set_ext_pri(c, "T", 1);
|
||||
/* If the AbsoluteTimeout is not reset to 0, we'll get an infinite loop */
|
||||
c->whentohangup = 0;
|
||||
c->_softhangup &= ~AST_SOFTHANGUP_TIMEOUT;
|
||||
continue;
|
||||
} else {
|
||||
if (c->cdr)
|
||||
ast_cdr_update(c);
|
||||
|
|
Reference in a new issue