dect
/
asterisk
Archived
13
0
Fork 0
Code Releases Activity

Fixing a potential buffer overflow in the manager command ModuleCheck. 

Though this overflow is exploitable remotely, we are NOT issuing a security
advisory for this since in order to exploit the overflow, the attacker would
have to establish an authenticated manager session AND have the system privilege.
By gaining this privilege, the attacker already has more powerful weapons at his
disposal than overflowing a buffer with a malformed manager header, so the vulnerability
in this case really lies with the authentication method that allowed the attacker to 
gain the system privilege in the first place.



git-svn-id: http://svn.digium.com/svn/asterisk/trunk@108529 f38db490-d61c-443f-a65b-d21fe96a405b
This commit is contained in:
mmichelson 2008-03-13 20:59:00 +00:00
parent 940afa0002
commit 721d85cdd0
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
main/manager.c
View File

@ -2634,14 +2634,14 @@ static int manager_modulecheck(struct mansession *s, const struct message *m)
} else {
cut = filename + strlen(filename);
}
sprintf(cut, ".so");
snprintf(cut, sizeof(filename) - cut - 1, ".so");
ast_log(LOG_DEBUG, "**** ModuleCheck .so file %s\n", filename);
res = ast_module_check(filename);
if (!res) {
astman_send_error(s, m, "Module not loaded");
return 0;
}
sprintf(cut, ".c");
snprintf(cut, sizeof(filename) - cut - 1, ".c");
ast_log(LOG_DEBUG, "**** ModuleCheck .c file %s\n", filename);
version = ast_file_version_find(filename);