dect
/
asterisk
Archived
13
0
Fork 0
Code Releases Activity

Go ahead and make this write unconditional. Making it conditional is more work 

in both the append and non-append modes.  Also, always truncating the partial
write makes the behavior of the function more consistent, where in any type of
write, no partial result is left in the buffer.

Thanks for the feedback, luigi


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@48109 f38db490-d61c-443f-a65b-d21fe96a405b
This commit is contained in:
russell 2006-11-29 17:37:31 +00:00
parent 230fa9e998
commit 700f9d585c
1 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
main/utils.c
View File

@ -997,16 +997,8 @@ int ast_dynamic_str_thread_build_va(struct ast_dynamic_str **buf, size_t max_len
return AST_DYNSTR_BUILD_FAILED;
(*buf)->len = need;
/* Truncate the previous attempt. This is only needed for the
* append operation because if the write is from the beginning,
* it will get automatically overwritten when this function
* gets called again. When appending, if this was not done,
* this function would be called over and over again, because
* each attempt would be appending more and more partial
* strings, never having enough space to finish.
*/
if (append)
(*buf)->str[offset] = '\0';
/* Truncate the partial write. */
(*buf)->str[offset] = '\0';
if (ts)
pthread_setspecific(ts->key, *buf);