Archived
14
0
Fork 0

There existed about a 1 in 4 billion chance that reading from /dev/urandom

would return LONG_MIN (1 in 9 quintillion if using 64-bit longs). Since there
is no positive equivalent of LONG_MIN, the result of labs() in this case is
unpredictable. This fixes that situation.

(closes issue #11336, reported and patched by sperreault)



git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89487 f38db490-d61c-443f-a65b-d21fe96a405b
This commit is contained in:
mmichelson 2007-11-21 18:19:22 +00:00
parent c0db75dd30
commit 40ff1f7b41

View file

@ -1140,7 +1140,7 @@ long int ast_random(void)
if (dev_urandom_fd >= 0) {
int read_res = read(dev_urandom_fd, &res, sizeof(res));
if (read_res > 0)
return labs(res);
return res < 0 ? ~res : res;
}
#endif
#ifdef linux