dect
/
asterisk
Archived
13
0
Fork 0
Code Releases Activity

Merged revisions 109226 via svnmerge from 

https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r109226 | mmichelson | 2008-03-17 17:05:49 -0500 (Mon, 17 Mar 2008) | 12 lines

Fix a logic flaw in the code that stores lock info which is displayed
via the "core show locks" command. The idea behind this section of code was
to remove the previous lock from the list if it was a trylock that had failed.
Unfortunately, instead of checking the status of the previous lock, we were referencing
the index immediately following the previous lock in the lock_info->locks array. 
The result of this problem, under the right circumstances, was that the lock which 
we currently in the process of attempting to acquire could "overwrite" the previous lock 
which was acquired. While this does not in any way affect typical operation, it *could*
lead to misleading "core show locks" output.



........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@109227 f38db490-d61c-443f-a65b-d21fe96a405b
This commit is contained in:
mmichelson 2008-03-17 22:06:44 +00:00
parent c10739a19d
commit 40a42d212f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
main/utils.c
View File

@ -611,7 +611,7 @@ void ast_store_lock_info(enum ast_lock_type type, const char *filename,
return;
}
if (i && lock_info->locks[i].pending == -1) {
if (i && lock_info->locks[i-1].pending == -1) {
/* The last lock on the list was one that this thread tried to lock but
* failed at doing so. It has now moved on to something else, so remove
* the old lock from the list. */