From 2cff22ef54be8f3eb7064254a59aec4e6aa76a2e Mon Sep 17 00:00:00 2001
From: Andreas Eversberg <jolly@eversberg.eu>
Date: Fri, 2 Nov 2018 09:28:48 +0100
Subject: [PATCH] Added little INSTALL document and fixed some compiler issues

---
 INSTALL       | 24 ++++++++++++++++++++++++
 configure.ac  |  4 ++--
 src/nmt/sms.c |  2 +-
 3 files changed, 27 insertions(+), 3 deletions(-)
 create mode 100644 INSTALL

diff --git a/INSTALL b/INSTALL
new file mode 100644
index 0000000..527a7b4
--- /dev/null
+++ b/INSTALL
@@ -0,0 +1,24 @@
+You need to have the folowing packages install:
+
+* automake, gcc for compilation
+* libasound2 for sound card support, which is what you need!
+* libsoapysdr or libuhd (developer) to support SDR
+* -> SoapySDR modules to support your SDR hardware
+* libimagamagick version >= 7 (developer) optionally for TV image display
+
+
+Generate "configure":
+
+$ autoreconf -if
+
+
+Run "configure":
+
+$ ./configure
+
+
+Build and install:
+
+$ make
+$ make install
+
diff --git a/configure.ac b/configure.ac
index 0e75496..dc71f53 100644
--- a/configure.ac
+++ b/configure.ac
@@ -15,7 +15,7 @@ AC_PROG_MAKE_SET
 AC_PROG_CC
 AC_PROG_CXX
 AC_PROG_INSTALL
-LT_INIT
+AC_PROG_RANLIB
 
 dnl checks for header files
 AC_HEADER_STDC
@@ -34,7 +34,7 @@ AC_ARG_WITH([soapy], [AS_HELP_STRING([--with-soapy], [compile with SoapySDR driv
 AC_ARG_WITH([imagemagick], [AS_HELP_STRING([--with-imagemagick], [compile with ImageMagick support @<:@default=check@:>@]) ], [], [with_imagemagick="check"])
 AS_IF([test "x$with_alsa" != xno], [PKG_CHECK_MODULES(ALSA, alsa >= 1.0, with_alsa=yes, with_alsa=no)])
 AS_IF([test "x$with_uhd" != xno], [PKG_CHECK_MODULES(UHD, uhd >= 3.0.0, with_sdr=yes with_uhd=yes, with_uhd=no)])
-AS_IF([test "x$with_soapy" != xno], [PKG_CHECK_MODULES(SOAPY, SoapySDR >= 0.6.0, with_sdr=yes with_soapy=yes, with_soapy=no)])
+AS_IF([test "x$with_soapy" != xno], [PKG_CHECK_MODULES(SOAPY, SoapySDR >= 0.5.0, with_sdr=yes with_soapy=yes, with_soapy=no)])
 AS_IF([test "x$with_imagemagick" != xno], [PKG_CHECK_MODULES(IMAGEMAGICK, ImageMagick >= 7.0.0, with_imagemagick=yes, with_imagemagick=no)])
 AM_CONDITIONAL(HAVE_ALSA, test "x$with_alsa" == "xyes" )
 AM_CONDITIONAL(HAVE_UHD, test "x$with_uhd" == "xyes" )
diff --git a/src/nmt/sms.c b/src/nmt/sms.c
index 4d8900d..37e3b2b 100644
--- a/src/nmt/sms.c
+++ b/src/nmt/sms.c
@@ -252,7 +252,7 @@ static int encode_userdata(uint8_t *data, const char *message)
 	j = 0;
 	pos = 0;
 	for (i = 0; message[i]; i++) {
-		if (message[i] >= 0)
+		if ((int8_t)message[i] >= 0)
 			character = message[i]; /* 0..127 */
 		else
 			character = '?'; /* 128..255 */