From c5989fe180465fe8839dd822424fd1c6765512ea Mon Sep 17 00:00:00 2001 From: Harald Welte Date: Mon, 19 Oct 2020 12:27:36 +0200 Subject: [PATCH] Use osmo_fd_setup() wherever applicable Change-Id: Ie093dea96ec8990368695c0c5824e0fe44fb8540 --- Transceiver52M/device/ipc/ipc-driver-test.c | 5 +---- Transceiver52M/device/ipc/ipc_chan.c | 7 +------ Transceiver52M/device/ipc/ipc_sock.c | 5 +---- 3 files changed, 3 insertions(+), 14 deletions(-) diff --git a/Transceiver52M/device/ipc/ipc-driver-test.c b/Transceiver52M/device/ipc/ipc-driver-test.c index 0cccbdaa..da53463b 100644 --- a/Transceiver52M/device/ipc/ipc-driver-test.c +++ b/Transceiver52M/device/ipc/ipc-driver-test.c @@ -394,10 +394,7 @@ int ipc_sock_init(const char *path, struct ipc_sock_state **global_state_var, return -1; } - bfd->when = OSMO_FD_READ; - bfd->cb = sock_callback_fn; - bfd->data = state; - bfd->priv_nr = n; + osmo_fd_setup(bfd, bfd->fd, OSMO_FD_READ, sock_callback_fn, state, n); rc = osmo_fd_register(bfd); if (rc < 0) { diff --git a/Transceiver52M/device/ipc/ipc_chan.c b/Transceiver52M/device/ipc/ipc_chan.c index af18aab6..50782b93 100644 --- a/Transceiver52M/device/ipc/ipc_chan.c +++ b/Transceiver52M/device/ipc/ipc_chan.c @@ -236,13 +236,8 @@ int ipc_chan_sock_accept(struct osmo_fd *bfd, unsigned int flags) return 0; } - conn_bfd->fd = rc; - conn_bfd->when = OSMO_FD_READ; - conn_bfd->cb = ipc_chan_sock_cb; - conn_bfd->data = state; - /* copy chan nr, required for proper bfd<->chan # mapping */ - conn_bfd->priv_nr = bfd->priv_nr; + osmo_fd_setup(conn_bfd, rc, OSMO_FD_READ, ipc_chan_sock_cb, state, bfd->priv_nr); if (osmo_fd_register(conn_bfd) != 0) { LOGP(DDEV, LOGL_ERROR, diff --git a/Transceiver52M/device/ipc/ipc_sock.c b/Transceiver52M/device/ipc/ipc_sock.c index 26865bfe..b014face 100644 --- a/Transceiver52M/device/ipc/ipc_sock.c +++ b/Transceiver52M/device/ipc/ipc_sock.c @@ -249,10 +249,7 @@ int ipc_sock_accept(struct osmo_fd *bfd, unsigned int flags) return 0; } - conn_bfd->fd = rc; - conn_bfd->when = OSMO_FD_READ; - conn_bfd->cb = ipc_sock_cb; - conn_bfd->data = state; + osmo_fd_setup(conn_bfd, rc, OSMO_FD_READ, ipc_sock_cb, state, 0); if (osmo_fd_register(conn_bfd) != 0) { LOGP(DDEV, LOGL_ERROR,