Update patch set 13

Browse Source

Patch Set 13:

> why keeping it in /opt and not in the workspace?  The per-job
 > directories on each slave are persistent, aren't they?  At least
 > when I log in via SSH I always see plenty of those directories?

They are not persistent in the sense that they get cleaned everytime by osmo-clean-workspace.sh, so the git directory stays there but the generated image would be cleaned, and then next time would need to be re-generated. A solution for this would be adding a env var or a parameter to osmo-clean-workspace.sh to have a list of directories to skip (it's apparently easy with git clean -e).

For now I decided to have it in /opt in a similar way as we already have the toolchain /opt/poky/, since the rootfs in /opt/qemu-img is mostly used readonly because we do all the work only inside /opt/qemu-img/osmo-trx which is actually fake since proot is bind-mounting it to our workspace. This way we set up the image once per jenkins node and we forget about it (we document it of course ;).

Patch-set: 13
Label: Code-Review=0

...

This commit is contained in:

Pau Espin Pedrol 2018-01-15 18:27:01 +00:00 committed by Gerrit Code Review

parent af78262357

commit 39c5bdfe26

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Show Stats Download Patch File Download Diff File Expand all files Collapse all files

Diff Content Not Available