Update patch set 3

Patch Set 3: (3 comments) Patch-set: 3 Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"lynxis lazus replied on the change"}
2022-08-08 18:27:13 +00:00 · 2022-08-08 18:27:13 +00:00 · 1a1531ad20
parent 2f682f3be4
commit 1a1531ad20
2 changed files with 140 additions and 86 deletions
--- a/190
+++ b/190
@ -1,6 +1,7 @@
 {
  "comments": [
    {
+      "unresolved": true,
      "key": {
        "uuid": "f4af4bd1_a8ba78a6",
        "filename": "Transceiver52M/device/xtrx/XTRXDevice.cpp",
@ -14,10 +15,10 @@
      "side": 1,
      "message": "20+20+20+20+20 is not 60 lol",
      "revId": "41729fc9e988f17cb71c4aeac65a62ae3bd3dbe9",
-      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
-      "unresolved": true
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
+      "unresolved": false,
      "key": {
        "uuid": "c0101ac3_8b6402d4",
        "filename": "Transceiver52M/device/xtrx/XTRXDevice.cpp",
@ -32,10 +33,10 @@
      "message": "Good point.",
      "parentUuid": "f4af4bd1_a8ba78a6",
      "revId": "41729fc9e988f17cb71c4aeac65a62ae3bd3dbe9",
-      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
-      "unresolved": false
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
+      "unresolved": true,
      "key": {
        "uuid": "6172ffb4_02b8e300",
        "filename": "Transceiver52M/device/xtrx/XTRXDevice.cpp",
@ -49,10 +50,10 @@
      "side": 1,
      "message": "I don\u0027t remember now how tx_paths/rx_pathsa re generated, but I bet it\u0027s always populated to be size() \u003d\u003d chans, and I doubt chans can be zero (int that case we should exit way before).",
      "revId": "41729fc9e988f17cb71c4aeac65a62ae3bd3dbe9",
-      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
-      "unresolved": true
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
+      "unresolved": false,
      "key": {
        "uuid": "855eff97_84d912f6",
        "filename": "Transceiver52M/device/xtrx/XTRXDevice.cpp",
@ -67,10 +68,10 @@
      "message": "Looks like it can be 0 if we don\u0027t specify rx/tx-path in the config file.\n\nPlus, does it really hurt to have here? Esp if no one remembers is it can be zero or not?",
      "parentUuid": "6172ffb4_02b8e300",
      "revId": "41729fc9e988f17cb71c4aeac65a62ae3bd3dbe9",
-      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
-      "unresolved": false
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
+      "unresolved": false,
      "key": {
        "uuid": "50271291_46dd43a7",
        "filename": "Transceiver52M/device/xtrx/XTRXDevice.cpp",
@ -85,10 +86,10 @@
      "message": "in trx_start() (osmo-trx.cpp):\n\n\t/* Generate vector of rx/tx_path: */\n\tfor (i \u003d 0; i \u003c trx-\u003ecfg.num_chans; i++) {\n\t\trx_paths.push_back(charp2str(trx-\u003ecfg.chans[i].rx_path));\n\t\ttx_paths.push_back(charp2str(trx-\u003ecfg.chans[i].tx_path));\n\t}\n\nSo it cannot be size()\u003d\u003d0 unless there\u0027s cnum_chans\u003d0, which shouldn\u0027t happen.\n\nIMHO having this check here is unnecesary and confusing for people reading the code.",
      "parentUuid": "855eff97_84d912f6",
      "revId": "41729fc9e988f17cb71c4aeac65a62ae3bd3dbe9",
-      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
-      "unresolved": false
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
+      "unresolved": true,
      "key": {
        "uuid": "6fe6c10d_7af407f1",
        "filename": "Transceiver52M/device/xtrx/XTRXDevice.cpp",
@ -102,10 +103,10 @@
      "side": 1,
      "message": "You can probably set those around line 42 out of the body of the function (constructor initializers).",
      "revId": "41729fc9e988f17cb71c4aeac65a62ae3bd3dbe9",
-      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
-      "unresolved": true
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
+      "unresolved": false,
      "key": {
        "uuid": "14aba0ee_0128a77f",
        "filename": "Transceiver52M/device/xtrx/XTRXDevice.cpp",
@ -120,10 +121,10 @@
      "message": "Yes, but it looks cleaner here and doesn\u0027t affect performance.",
      "parentUuid": "6fe6c10d_7af407f1",
      "revId": "41729fc9e988f17cb71c4aeac65a62ae3bd3dbe9",
-      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
-      "unresolved": false
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
+      "unresolved": false,
      "key": {
        "uuid": "4595045f_1051697f",
        "filename": "Transceiver52M/device/xtrx/XTRXDevice.cpp",
@ -138,10 +139,10 @@
      "message": "I disagree, but it\u0027s bike-shed talking anyway, so keep it this way if you prefer, np.",
      "parentUuid": "14aba0ee_0128a77f",
      "revId": "41729fc9e988f17cb71c4aeac65a62ae3bd3dbe9",
-      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
-      "unresolved": false
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
+      "unresolved": true,
      "key": {
        "uuid": "f3b3a4da_c8d1d742",
        "filename": "Transceiver52M/device/xtrx/XTRXDevice.cpp",
@ -155,10 +156,10 @@
      "side": 1,
      "message": "trailing whitespace",
      "revId": "41729fc9e988f17cb71c4aeac65a62ae3bd3dbe9",
-      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
-      "unresolved": true
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
+      "unresolved": false,
      "key": {
        "uuid": "5adf35e0_1116981e",
        "filename": "Transceiver52M/device/xtrx/XTRXDevice.cpp",
@ -173,10 +174,10 @@
      "message": "Ack",
      "parentUuid": "f3b3a4da_c8d1d742",
      "revId": "41729fc9e988f17cb71c4aeac65a62ae3bd3dbe9",
-      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
-      "unresolved": false
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
+      "unresolved": true,
      "key": {
        "uuid": "b5c56b22_409ad32d",
        "filename": "Transceiver52M/device/xtrx/XTRXDevice.cpp",
@ -190,10 +191,10 @@
      "side": 1,
      "message": "would be great checking other devices to see if we actually return true here.",
      "revId": "41729fc9e988f17cb71c4aeac65a62ae3bd3dbe9",
-      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
-      "unresolved": true
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
+      "unresolved": true,
      "key": {
        "uuid": "5d21dc6f_8f690544",
        "filename": "Transceiver52M/device/xtrx/XTRXDevice.cpp",
@ -208,10 +209,10 @@
      "message": "What do you mean by \"other devices\" here?",
      "parentUuid": "b5c56b22_409ad32d",
      "revId": "41729fc9e988f17cb71c4aeac65a62ae3bd3dbe9",
-      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
-      "unresolved": true
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
+      "unresolved": true,
      "key": {
        "uuid": "46772c72_f9425229",
        "filename": "Transceiver52M/device/xtrx/XTRXDevice.cpp",
@ -226,10 +227,28 @@
      "message": "Other device implementations. For instance UHDDevice does:\n\n\tif (started) {\n\t\tLOGC(DDEV, ERROR) \u003c\u003c \"Device already started\";\n\t\treturn false;\n\t}\n\nSo fine here :) Maybe wanna add a LOGC like UHDDevice.",
      "parentUuid": "5d21dc6f_8f690544",
      "revId": "41729fc9e988f17cb71c4aeac65a62ae3bd3dbe9",
-      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
-      "unresolved": true
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
+      "unresolved": false,
+      "key": {
+        "uuid": "c6de38f7_ef0b9e67",
+        "filename": "Transceiver52M/device/xtrx/XTRXDevice.cpp",
+        "patchSetId": 1
+      },
+      "lineNbr": 177,
+      "author": {
+        "id": 1000015
+      },
+      "writtenOn": "2022-08-08T18:27:13Z",
+      "side": 1,
+      "message": "Done",
+      "parentUuid": "46772c72_f9425229",
+      "revId": "41729fc9e988f17cb71c4aeac65a62ae3bd3dbe9",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
+    {
+      "unresolved": true,
      "key": {
        "uuid": "d6231c84_5b67456c",
        "filename": "Transceiver52M/device/xtrx/XTRXDevice.cpp",
@ -243,10 +262,10 @@
      "side": 1,
      "message": "so rx_path/tx_path VTY params are not really used yet?",
      "revId": "41729fc9e988f17cb71c4aeac65a62ae3bd3dbe9",
-      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
-      "unresolved": true
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
+      "unresolved": false,
      "key": {
        "uuid": "eae5c318_952bbc94",
        "filename": "Transceiver52M/device/xtrx/XTRXDevice.cpp",
@ -261,10 +280,10 @@
      "message": "Ack",
      "parentUuid": "d6231c84_5b67456c",
      "revId": "41729fc9e988f17cb71c4aeac65a62ae3bd3dbe9",
-      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
-      "unresolved": false
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
+      "unresolved": true,
      "key": {
        "uuid": "19e204d5_9fb0c83b",
        "filename": "Transceiver52M/device/xtrx/XTRXDevice.cpp",
@ -278,10 +297,10 @@
      "side": 1,
      "message": "trailing whitespace",
      "revId": "41729fc9e988f17cb71c4aeac65a62ae3bd3dbe9",
-      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
-      "unresolved": true
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
+      "unresolved": false,
      "key": {
        "uuid": "cebdf352_31e9876c",
        "filename": "Transceiver52M/device/xtrx/XTRXDevice.cpp",
@ -296,10 +315,10 @@
      "message": "Ack",
      "parentUuid": "19e204d5_9fb0c83b",
      "revId": "41729fc9e988f17cb71c4aeac65a62ae3bd3dbe9",
-      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
-      "unresolved": false
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
+      "unresolved": true,
      "key": {
        "uuid": "14ca8351_c9af7e55",
        "filename": "Transceiver52M/device/xtrx/XTRXDevice.cpp",
@ -313,10 +332,10 @@
      "side": 1,
      "message": "trailing whitespace",
      "revId": "41729fc9e988f17cb71c4aeac65a62ae3bd3dbe9",
-      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
-      "unresolved": true
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
+      "unresolved": false,
      "key": {
        "uuid": "ba653e64_2a9cafa3",
        "filename": "Transceiver52M/device/xtrx/XTRXDevice.cpp",
@ -331,10 +350,10 @@
      "message": "Ack",
      "parentUuid": "14ca8351_c9af7e55",
      "revId": "41729fc9e988f17cb71c4aeac65a62ae3bd3dbe9",
-      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
-      "unresolved": false
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
+      "unresolved": true,
      "key": {
        "uuid": "a690f283_16f440b0",
        "filename": "Transceiver52M/device/xtrx/XTRXDevice.cpp",
@ -348,10 +367,10 @@
      "side": 1,
      "message": "db - 30 ?",
      "revId": "41729fc9e988f17cb71c4aeac65a62ae3bd3dbe9",
-      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
-      "unresolved": true
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
+      "unresolved": false,
      "key": {
        "uuid": "e4464dc3_1a6597af",
        "filename": "Transceiver52M/device/xtrx/XTRXDevice.cpp",
@ -366,10 +385,10 @@
      "message": "I\u0027ll ask Sergey why is it done this way but I\u0027m sure there is a reason for that.",
      "parentUuid": "a690f283_16f440b0",
      "revId": "41729fc9e988f17cb71c4aeac65a62ae3bd3dbe9",
-      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
-      "unresolved": false
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
+      "unresolved": false,
      "key": {
        "uuid": "79739f30_7abc4806",
        "filename": "Transceiver52M/device/xtrx/XTRXDevice.cpp",
@ -384,10 +403,10 @@
      "message": "Then please document so.",
      "parentUuid": "e4464dc3_1a6597af",
      "revId": "41729fc9e988f17cb71c4aeac65a62ae3bd3dbe9",
-      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
-      "unresolved": false
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
+      "unresolved": true,
      "key": {
        "uuid": "8dc3f6ce_bbb582e0",
        "filename": "Transceiver52M/device/xtrx/XTRXDevice.cpp",
@ -401,10 +420,10 @@
      "side": 1,
      "message": "Please fix indenting for params, they should be under the \"(\" character. ( in all functions!).",
      "revId": "41729fc9e988f17cb71c4aeac65a62ae3bd3dbe9",
-      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
-      "unresolved": true
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
+      "unresolved": false,
      "key": {
        "uuid": "35eef6db_5695bfe1",
        "filename": "Transceiver52M/device/xtrx/XTRXDevice.cpp",
@ -419,10 +438,10 @@
      "message": "Ack",
      "parentUuid": "8dc3f6ce_bbb582e0",
      "revId": "41729fc9e988f17cb71c4aeac65a62ae3bd3dbe9",
-      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
-      "unresolved": false
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
+      "unresolved": true,
      "key": {
        "uuid": "7d46c9e4_451b6a16",
        "filename": "Transceiver52M/device/xtrx/XTRXDevice.cpp",
@ -436,10 +455,10 @@
      "side": 1,
      "message": "You probably need to add code to use smpl_buf in here later on, not needed for now though.",
      "revId": "41729fc9e988f17cb71c4aeac65a62ae3bd3dbe9",
-      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
-      "unresolved": true
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
+      "unresolved": false,
      "key": {
        "uuid": "394a7b4a_7bdf6d80",
        "filename": "Transceiver52M/device/xtrx/XTRXDevice.cpp",
@ -454,10 +473,10 @@
      "message": "Ack",
      "parentUuid": "7d46c9e4_451b6a16",
      "revId": "41729fc9e988f17cb71c4aeac65a62ae3bd3dbe9",
-      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
-      "unresolved": false
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
+      "unresolved": true,
      "key": {
        "uuid": "1de39279_6940d22f",
        "filename": "Transceiver52M/device/xtrx/XTRXDevice.cpp",
@ -471,10 +490,10 @@
      "side": 1,
      "message": "I think this should never happen, because Transceiver stops threads calling this function on those conditions.",
      "revId": "41729fc9e988f17cb71c4aeac65a62ae3bd3dbe9",
-      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
-      "unresolved": true
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
+      "unresolved": false,
      "key": {
        "uuid": "dd0fe87a_6929c2a0",
        "filename": "Transceiver52M/device/xtrx/XTRXDevice.cpp",
@ -489,10 +508,10 @@
      "message": "Does it hurt to check, just to be sure?",
      "parentUuid": "1de39279_6940d22f",
      "revId": "41729fc9e988f17cb71c4aeac65a62ae3bd3dbe9",
-      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
-      "unresolved": false
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
+      "unresolved": false,
      "key": {
        "uuid": "cfc24283_4a9c9c4c",
        "filename": "Transceiver52M/device/xtrx/XTRXDevice.cpp",
@ -507,10 +526,10 @@
      "message": "It adds confusing about how the system is expected to work, and makes it difficult to refactor later (because looks like different devices expect the generic framework to work in different ways). For instance UHDDevice doesn\u0027t do this kind of check.",
      "parentUuid": "dd0fe87a_6929c2a0",
      "revId": "41729fc9e988f17cb71c4aeac65a62ae3bd3dbe9",
-      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
-      "unresolved": false
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
+      "unresolved": true,
      "key": {
        "uuid": "444b534b_9c8a3911",
        "filename": "Transceiver52M/device/xtrx/XTRXDevice.cpp",
@ -524,10 +543,10 @@
      "side": 1,
      "message": "No need for brackets here.",
      "revId": "41729fc9e988f17cb71c4aeac65a62ae3bd3dbe9",
-      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
-      "unresolved": true
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
+      "unresolved": false,
      "key": {
        "uuid": "e8a34919_81bd7896",
        "filename": "Transceiver52M/device/xtrx/XTRXDevice.cpp",
@ -542,10 +561,10 @@
      "message": "Ack",
      "parentUuid": "444b534b_9c8a3911",
      "revId": "41729fc9e988f17cb71c4aeac65a62ae3bd3dbe9",
-      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
-      "unresolved": false
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
+      "unresolved": true,
      "key": {
        "uuid": "c59476ae_e2fd8abd",
        "filename": "Transceiver52M/device/xtrx/XTRXDevice.cpp",
@ -559,10 +578,10 @@
      "side": 1,
      "message": "probably want to add \"(Not implemented)\" here.",
      "revId": "41729fc9e988f17cb71c4aeac65a62ae3bd3dbe9",
-      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
-      "unresolved": true
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
+      "unresolved": false,
      "key": {
        "uuid": "b7789f95_cca99ca4",
        "filename": "Transceiver52M/device/xtrx/XTRXDevice.cpp",
@ -577,10 +596,10 @@
      "message": "Ack",
      "parentUuid": "c59476ae_e2fd8abd",
      "revId": "41729fc9e988f17cb71c4aeac65a62ae3bd3dbe9",
-      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
-      "unresolved": false
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
+      "unresolved": true,
      "key": {
        "uuid": "899b65ab_0778ab12",
        "filename": "Transceiver52M/device/xtrx/XTRXDevice.cpp",
@ -594,10 +613,10 @@
      "side": 1,
      "message": "trailing whitespace",
      "revId": "41729fc9e988f17cb71c4aeac65a62ae3bd3dbe9",
-      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
-      "unresolved": true
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
+      "unresolved": false,
      "key": {
        "uuid": "a9a29504_8f440ce0",
        "filename": "Transceiver52M/device/xtrx/XTRXDevice.cpp",
@ -612,10 +631,10 @@
      "message": "Ack",
      "parentUuid": "899b65ab_0778ab12",
      "revId": "41729fc9e988f17cb71c4aeac65a62ae3bd3dbe9",
-      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
-      "unresolved": false
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
+      "unresolved": true,
      "key": {
        "uuid": "cf9fdfe5_3f3fedce",
        "filename": "Transceiver52M/device/xtrx/XTRXDevice.cpp",
@ -629,10 +648,10 @@
      "side": 1,
      "message": "Since requiresRadioAlign() returns false, this should never be called, right?",
      "revId": "41729fc9e988f17cb71c4aeac65a62ae3bd3dbe9",
-      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
-      "unresolved": true
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
+      "unresolved": false,
      "key": {
        "uuid": "8834a2d2_c8e03ed8",
        "filename": "Transceiver52M/device/xtrx/XTRXDevice.cpp",
@ -647,10 +666,10 @@
      "message": "Correct. But it\u0027s an abstract virtual function and thus must be implemented.",
      "parentUuid": "cf9fdfe5_3f3fedce",
      "revId": "41729fc9e988f17cb71c4aeac65a62ae3bd3dbe9",
-      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
-      "unresolved": false
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
+      "unresolved": true,
      "key": {
        "uuid": "6b360cdc_30646f91",
        "filename": "Transceiver52M/device/xtrx/XTRXDevice.cpp",
@ -664,10 +683,10 @@
      "side": 1,
      "message": "Fix indent.",
      "revId": "41729fc9e988f17cb71c4aeac65a62ae3bd3dbe9",
-      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
-      "unresolved": true
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
+      "unresolved": false,
      "key": {
        "uuid": "ba77abe7_da14f7a6",
        "filename": "Transceiver52M/device/xtrx/XTRXDevice.cpp",
@ -682,10 +701,10 @@
      "message": "Ack",
      "parentUuid": "6b360cdc_30646f91",
      "revId": "41729fc9e988f17cb71c4aeac65a62ae3bd3dbe9",
-      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
-      "unresolved": false
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
+      "unresolved": true,
      "key": {
        "uuid": "e334e741_16a64726",
        "filename": "contrib/systemd/Makefile.am",
@ -699,10 +718,10 @@
      "side": 1,
      "message": "That\u0027s wrong I\u0027d say. You want to keep all files in EXTRA_DIST, because someone else may decide to compile with different TRX device support from the archive later on, so all of themm need to be available.",
      "revId": "41729fc9e988f17cb71c4aeac65a62ae3bd3dbe9",
-      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
-      "unresolved": true
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
+      "unresolved": false,
      "key": {
        "uuid": "7e773aa3_ad33abfb",
        "filename": "contrib/systemd/Makefile.am",
@ -717,10 +736,10 @@
      "message": "Ack",
      "parentUuid": "e334e741_16a64726",
      "revId": "41729fc9e988f17cb71c4aeac65a62ae3bd3dbe9",
-      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
-      "unresolved": false
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
+      "unresolved": true,
      "key": {
        "uuid": "dc6fbf6a_1c526f94",
        "filename": "doc/examples/osmo-trx-xtrx/osmo-trx-xtrx.cfg",
@ -734,10 +753,10 @@
      "side": 1,
      "message": "Do you use same names for tx/rx paths as LimeSUite? Otherwise this is wrong.",
      "revId": "41729fc9e988f17cb71c4aeac65a62ae3bd3dbe9",
-      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
-      "unresolved": true
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
+      "unresolved": false,
      "key": {
        "uuid": "a18c4b59_14a569fc",
        "filename": "doc/examples/osmo-trx-xtrx/osmo-trx-xtrx.cfg",
@ -752,8 +771,7 @@
      "message": "Ok, I think we should remove these since we\u0027re ignoring them anyway. We\u0027re not specifying them for UmTRX as well since the driver knows better which path to use, based on frequency.",
      "parentUuid": "dc6fbf6a_1c526f94",
      "revId": "41729fc9e988f17cb71c4aeac65a62ae3bd3dbe9",
-      "serverId": "035e6965-6537-41bd-912c-053f3cf69326",
-      "unresolved": false
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    }
  ]
 }
--- a/36
+++ b/36
@ -51,6 +51,24 @@
      "revId": "dccaf6ce8e7ff5a79204cdaecac6b1145d570cde",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "47debce2_5df9dcd8",
+        "filename": "Transceiver52M/device/xtrx/XTRXDevice.cpp",
+        "patchSetId": 3
+      },
+      "lineNbr": 459,
+      "author": {
+        "id": 1000015
+      },
+      "writtenOn": "2022-08-08T18:27:13Z",
+      "side": 1,
+      "message": "Done",
+      "parentUuid": "6f2e19ff_28fb9b58",
+      "revId": "dccaf6ce8e7ff5a79204cdaecac6b1145d570cde",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
    {
      "unresolved": true,
      "key": {
@ -67,6 +85,24 @@
      "message": "You miss adding osmo-trx-xtrx.service here.",
      "revId": "dccaf6ce8e7ff5a79204cdaecac6b1145d570cde",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "0c9e9017_1ccf18fe",
+        "filename": "contrib/systemd/Makefile.am",
+        "patchSetId": 3
+      },
+      "lineNbr": 4,
+      "author": {
+        "id": 1000015
+      },
+      "writtenOn": "2022-08-08T18:27:13Z",
+      "side": 1,
+      "message": "Done",
+      "parentUuid": "7a4bea7b_42dee340",
+      "revId": "dccaf6ce8e7ff5a79204cdaecac6b1145d570cde",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    }
  ]
 }