From f678caa819785d7726ea84afca4227c42814293d Mon Sep 17 00:00:00 2001 From: Alexander Couzens Date: Sat, 5 Sep 2020 23:08:17 +0200 Subject: [PATCH] Revert "sip: Specify invite contact tag" This reverts commit 52b2afce2ca902bbae4a550d03d471be784efe28. The contact header is generated by the original sofia-sip library. By adding the contact header explicit as user header it violates the SIP RFC because sofia will add the Contact header to the BYE message as well. Let's fix the bugs in the freeswitch sofia-sip and make it compatible (not bug compatible) with the original sofia-sip. Change-Id: I712f17fecbc372d1e486e80673a548e281b37800 --- src/sip.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/sip.c b/src/sip.c index 61916c9..c635542 100644 --- a/src/sip.c +++ b/src/sip.c @@ -597,9 +597,6 @@ static int send_invite(struct sip_agent *agent, struct sip_call_leg *leg, called_num, agent->app->sip.remote_addr, agent->app->sip.remote_port); - char *contact = talloc_asprintf(leg, "sip:%s:%d", - agent->app->sip.local_addr, - agent->app->sip.local_port); char *sdp = sdp_create_file(leg, other, sdp_sendrecv); leg->state = SIP_CC_INITIAL; @@ -607,7 +604,6 @@ static int send_invite(struct sip_agent *agent, struct sip_call_leg *leg, nua_invite(leg->nua_handle, SIPTAG_FROM_STR(from), SIPTAG_TO_STR(to), - SIPTAG_CONTACT_STR(contact), NUTAG_MEDIA_ENABLE(0), SIPTAG_CONTENT_TYPE_STR("application/sdp"), SIPTAG_PAYLOAD_STR(sdp), @@ -616,7 +612,6 @@ static int send_invite(struct sip_agent *agent, struct sip_call_leg *leg, leg->base.call->remote = &leg->base; talloc_free(from); talloc_free(to); - talloc_free(contact); talloc_free(sdp); return 0; }