coverity: Address two issues found by coverity

Add NULL check in the case of MNCC disconnect that was missing and
add an assert to show that at this point the other leg must exist.

Fixes: CID#80799, CID#80800, 80801
changes/26/126/1
Holger Hans Peter Freyther 7 years ago
parent adc7484a0c
commit bec32eb207
  1. 6
      src/app.c
  2. 1
      src/mncc.c

@ -44,8 +44,10 @@ void app_mncc_disconnected(struct mncc_connection *conn)
*/
LOGP(DAPP, LOGL_NOTICE,
"Going to release call(%u) due MNCC.\n", call->id);
call_leg_release(call->initial);
call_leg_release(call->remote);
if (call->initial)
call_leg_release(call->initial);
if (call->remote)
call_leg_release(call->remote);
}
}

@ -167,6 +167,7 @@ static void mncc_call_leg_connect(struct call_leg *_leg)
leg = (struct mncc_call_leg *) _leg;
other = call_leg_other(_leg);
OSMO_ASSERT(other);
if (!send_rtp_connect(leg, other))
return;

Loading…
Cancel
Save