From 676777c5f905a7f07a962e6fd7b84505257fc254 Mon Sep 17 00:00:00 2001 From: Daniel Willmann Date: Wed, 22 Nov 2023 12:42:17 +0100 Subject: [PATCH] libgtp: Check for all successful create_pdp_conf causes Related: OS#6268 Change-Id: I11ce72908c2dfb983887e6c1db316fd7de42f027 --- TODO-RELEASE | 1 + src/sgsn/sgsn_libgtp.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/TODO-RELEASE b/TODO-RELEASE index 1c5d61f56..bb4f90042 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -1 +1,2 @@ #component what description / commit summary line +libgtp > 1.10 use gtp_cause_successful() diff --git a/src/sgsn/sgsn_libgtp.c b/src/sgsn/sgsn_libgtp.c index 0b6da6228..9edd0c60e 100644 --- a/src/sgsn/sgsn_libgtp.c +++ b/src/sgsn/sgsn_libgtp.c @@ -417,7 +417,7 @@ static int create_pdp_conf(struct pdp_t *pdp, void *cbp, int cause) } /* Check for cause value if it was really successful */ - if (cause != GTPCAUSE_ACC_REQ) { + if (!gtp_cause_successful(cause)) { reject_cause = cause_map(gtp2sm_cause_map, cause, GSM_CAUSE_ACT_REJ_GGSN); goto reject;