91 lines
3.0 KiB
Plaintext
91 lines
3.0 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "f40c5b66_8df2a245",
|
|
"filename": "scripts/osmo_trap2cgi.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 193,
|
|
"author": {
|
|
"id": 1000008
|
|
},
|
|
"writtenOn": "2019-06-19T16:07:35Z",
|
|
"side": 1,
|
|
"message": "We need to break this recursion as well.",
|
|
"revId": "5869a38cd563b82f934059d193194749e7ca576c",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
|
"unresolved": true
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "85ca8e60_2723e2d5",
|
|
"filename": "scripts/osmo_trap2cgi.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 211,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2019-06-19T15:43:58Z",
|
|
"side": 1,
|
|
"message": "I don\u0027t know how this framework works, but are you sure keeping ctrl_client in a while True loop is fine? For instance this function conn_client looks like will block always here. Just to make sure.",
|
|
"revId": "5869a38cd563b82f934059d193194749e7ca576c",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
|
"unresolved": true
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "5b3343a0_26ea3928",
|
|
"filename": "scripts/osmo_trap2cgi.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 211,
|
|
"author": {
|
|
"id": 1000008
|
|
},
|
|
"writtenOn": "2019-06-19T15:49:20Z",
|
|
"side": 1,
|
|
"message": "We\u0027re more or less in the same boat then. :-)\nAs far as I can tell conn_client (re-)connects - see also line 215 - to the ctrl port and ctrl_client reads the traps in an infinite loop (or before in an infinite tail-recursion). If anything goes wrong in the exception handlers conn_client is called again, which re-establishes the connection.",
|
|
"parentUuid": "85ca8e60_2723e2d5",
|
|
"revId": "5869a38cd563b82f934059d193194749e7ca576c",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
|
"unresolved": true
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "ecc398ed_4a427df5",
|
|
"filename": "scripts/osmo_trap2cgi.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 215,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2019-06-19T15:58:10Z",
|
|
"side": 1,
|
|
"message": "Then we should turn this recursion into a while True.",
|
|
"revId": "5869a38cd563b82f934059d193194749e7ca576c",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
|
"unresolved": true
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "b027e520_e63c1125",
|
|
"filename": "scripts/osmo_trap2cgi.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 215,
|
|
"author": {
|
|
"id": 1000008
|
|
},
|
|
"writtenOn": "2019-06-19T16:07:35Z",
|
|
"side": 1,
|
|
"message": "Yes, see also my generic comment. So I\u0027ll try to get the recursion out of this script. Maybe Max can share his ideas why he used it in the first place.",
|
|
"parentUuid": "ecc398ed_4a427df5",
|
|
"revId": "5869a38cd563b82f934059d193194749e7ca576c",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
|
"unresolved": true
|
|
}
|
|
]
|
|
} |