osmo-python-tests/8f200fc1f551a18be7d7d24c70b01ddf25a04d89

{
  "comments": [
    {
      "unresolved": false,
      "key": {
        "uuid": "c845454c_81c40959",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 5
      },
      "lineNbr": 0,
      "author": {
        "id": 1000005
      },
      "writtenOn": "2023-02-13T01:20:47Z",
      "side": 1,
      "message": "i\u0027m not aware of these dummy sockets but if this fixes a problem, looks good to me",
      "revId": "8f200fc1f551a18be7d7d24c70b01ddf25a04d89",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "541829b4_6401f3c7",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 5
      },
      "lineNbr": 0,
      "author": {
        "id": 1000074
      },
      "writtenOn": "2023-02-20T10:43:10Z",
      "side": 1,
      "message": "I personally vote for fixing it the proper way instead of having file names in one project god knows where they come from.\nLet\u0027s see what others think.",
      "revId": "8f200fc1f551a18be7d7d24c70b01ddf25a04d89",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "d2d4c48a_2234791c",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 5
      },
      "lineNbr": 0,
      "author": {
        "id": 1000005
      },
      "writtenOn": "2023-02-26T22:19:53Z",
      "side": 1,
      "message": "what would be the proper way?",
      "parentUuid": "541829b4_6401f3c7",
      "revId": "8f200fc1f551a18be7d7d24c70b01ddf25a04d89",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "6a5527ad_23b54503",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 5
      },
      "lineNbr": 0,
      "author": {
        "id": 1000074
      },
      "writtenOn": "2023-02-27T10:54:01Z",
      "side": 1,
      "message": "Having each python app/file creating those specific files register them to be cleaned up, and not being done blindly by the lib (who is not really creating them), as presented here.",
      "parentUuid": "d2d4c48a_2234791c",
      "revId": "8f200fc1f551a18be7d7d24c70b01ddf25a04d89",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "8c8e5a22_44c37858",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 5
      },
      "lineNbr": 0,
      "author": {
        "id": 1000229
      },
      "writtenOn": "2023-03-26T19:52:37Z",
      "side": 1,
      "message": "In general, I\u0027m always for fixing things the \u0027proper\u0027 way. But the way it looks, nobody is going to change those socket file names any time soon. And then, still, that alone still wouldn\u0027t break anything. Doing what you describe would take a lot more time vs. this which is a quick fix that doesn\u0027t complicate anything/could be built upon when writing a \u0027proper\u0027 fix (by replacing the string literal with whatever is passed by the respective test component)",
      "parentUuid": "6a5527ad_23b54503",
      "revId": "8f200fc1f551a18be7d7d24c70b01ddf25a04d89",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "14381a0f_f936dc2f",
        "filename": "scripts/osmotestconfig.py",
        "patchSetId": 5
      },
      "lineNbr": 80,
      "author": {
        "id": 1000074
      },
      "writtenOn": "2023-01-24T10:04:38Z",
      "side": 1,
      "message": "So who is creating this tmp_dummy_sock? I don\u0027t find any other reference to it in osmo-python-tests.",
      "revId": "8f200fc1f551a18be7d7d24c70b01ddf25a04d89",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "844c4e63_fa7ced61",
        "filename": "scripts/osmotestconfig.py",
        "patchSetId": 5
      },
      "lineNbr": 80,
      "author": {
        "id": 1000229
      },
      "writtenOn": "2023-02-12T20:30:22Z",
      "side": 1,
      "message": "The files are created by the `ctrl_test_runner.py` scripts of several projects through binaries that support the `-r` option for creating command listener sockets.\n\n```\n$ ag tmp_dummy_sock\nosmo-bsc-nat/tests/ctrl_test_runner.py\n150:        os.unlink(\"tmp_dummy_sock\")\n153:        return [\"./src/osmo-bsc-nat/osmo-bsc-nat\", \"-r\", \"tmp_dummy_sock\", \"-c\",\n\nosmo-hnbgw/tests/ctrl_test_runner.py\n150:        os.unlink(\"tmp_dummy_sock\")\n153:        return [\"./src/osmo-hnbgw/osmo-hnbgw\", \"-r\", \"tmp_dummy_sock\", \"-c\",\n\ndocker-playground/osmo-bsc-master/osmo-bsc/tests/ctrl_test_runner.py\n150:        os.unlink(\"tmp_dummy_sock\")\n153:        return [\"./src/osmo-bsc/osmo-bsc\", \"-r\", \"tmp_dummy_sock\", \"-c\",\n573:        os.unlink(\"tmp_dummy_sock\")\n576:        return [\"./src/osmo-bsc/osmo-bsc\", \"-r\", \"tmp_dummy_sock\", \"-c\",\n610:        os.unlink(\"tmp_dummy_sock\")\n613:        return [\"./src/osmo-bsc/osmo-bsc\", \"-r\", \"tmp_dummy_sock\", \"-c\",\n\nosmo-bsc/tests/ctrl_test_runner.py\n150:        os.unlink(\"tmp_dummy_sock\")\n153:        return [\"./src/osmo-bsc/osmo-bsc\", \"-r\", \"tmp_dummy_sock\", \"-c\",\n573:        os.unlink(\"tmp_dummy_sock\")\n576:        return [\"./src/osmo-bsc/osmo-bsc\", \"-r\", \"tmp_dummy_sock\", \"-c\",\n610:        os.unlink(\"tmp_dummy_sock\")\n613:        return [\"./src/osmo-bsc/osmo-bsc\", \"-r\", \"tmp_dummy_sock\", \"-c\",\n\nopenbsc/openbsc/tests/ctrl_test_runner.py\n155:        os.unlink(\"tmp_dummy_sock\")\n158:        return [\"./src/osmo-bsc/osmo-bsc-sccplite\", \"-r\", \"tmp_dummy_sock\", \"-c\",\n```",
      "parentUuid": "14381a0f_f936dc2f",
      "revId": "8f200fc1f551a18be7d7d24c70b01ddf25a04d89",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "97c240cd_7130f0fc",
        "filename": "scripts/osmotestconfig.py",
        "patchSetId": 5
      },
      "lineNbr": 80,
      "author": {
        "id": 1000074
      },
      "writtenOn": "2023-02-13T09:13:41Z",
      "side": 1,
      "message": "It\u0027s the first time I actually realize the existence of this socket. I\u0027m not even sure about its purpose :O\n\nIn any case, this file name looks per-project specific. I\u0027d maybe add a new optional param to copy_config which users inside each project can pass a list of patterns to ignore.",
      "parentUuid": "844c4e63_fa7ced61",
      "revId": "8f200fc1f551a18be7d7d24c70b01ddf25a04d89",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "6768e90a_54853f4a",
        "filename": "scripts/osmotestconfig.py",
        "patchSetId": 5
      },
      "lineNbr": 80,
      "author": {
        "id": 1000229
      },
      "writtenOn": "2023-02-18T18:02:16Z",
      "side": 1,
      "message": "So that would boil down to adding a new parameter to `osmotestconfig.py` to account for ignores being passed up the call stack in the script, plus changing the invocation of this script in each project to pass the socket file to be ignored.\n\nMaybe for now it\u0027s easier/quicker to just ignore the given file name since it\u0027s not likely to change any time soon (?). Of course the parameter solution would be cleaner.",
      "parentUuid": "97c240cd_7130f0fc",
      "revId": "8f200fc1f551a18be7d7d24c70b01ddf25a04d89",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    }
  ]
}