From 7b51be797e0845835666ac9c57b2eb66bfeada76 Mon Sep 17 00:00:00 2001 From: Gerrit User 1000229 <1000229@035e6965-6537-41bd-912c-053f3cf69326> Date: Sat, 18 Feb 2023 18:02:16 +0000 Subject: [PATCH] Update patch set 5 Patch Set 5: (1 comment) Patch-set: 5 Attention: {"person_ident":"Gerrit User 1000229 \u003c1000229@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"arehbein replied on the change"} Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"arehbein replied on the change"} --- 8f200fc1f551a18be7d7d24c70b01ddf25a04d89 | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/8f200fc1f551a18be7d7d24c70b01ddf25a04d89 b/8f200fc1f551a18be7d7d24c70b01ddf25a04d89 index cbb1d87..1b09d62 100644 --- a/8f200fc1f551a18be7d7d24c70b01ddf25a04d89 +++ b/8f200fc1f551a18be7d7d24c70b01ddf25a04d89 @@ -69,6 +69,24 @@ "parentUuid": "844c4e63_fa7ced61", "revId": "8f200fc1f551a18be7d7d24c70b01ddf25a04d89", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" + }, + { + "unresolved": true, + "key": { + "uuid": "6768e90a_54853f4a", + "filename": "scripts/osmotestconfig.py", + "patchSetId": 5 + }, + "lineNbr": 80, + "author": { + "id": 1000229 + }, + "writtenOn": "2023-02-18T18:02:16Z", + "side": 1, + "message": "So that would boil down to adding a new parameter to `osmotestconfig.py` to account for ignores being passed up the call stack in the script, plus changing the invocation of this script in each project to pass the socket file to be ignored.\n\nMaybe for now it\u0027s easier/quicker to just ignore the given file name since it\u0027s not likely to change any time soon (?). Of course the parameter solution would be cleaner.", + "parentUuid": "97c240cd_7130f0fc", + "revId": "8f200fc1f551a18be7d7d24c70b01ddf25a04d89", + "serverId": "035e6965-6537-41bd-912c-053f3cf69326" } ] } \ No newline at end of file