cellular-infrastructure
/
osmo-pcu
mirror of https://gerrit.osmocom.org/osmo-pcu
9
0
Fork 1
Code Issues Releases Wiki Activity
osmo-pcu/src
History
Vadim Yanitskiy db56a3563e encoding: use CSN.1 codec to generate Packet Uplink Assignment 
It's quite odd to see that in write_packet_downlink_assignment()
we initialize an 'RlcMacDownlink_t', so then the caller can use
the power of CSN.1 codec to generate the final sequence of bytes
to be transmitted, while in write_packet_uplink_assignment() we
already compose the final RLC/MAC message straight away using
the low-level bitvec API (like bitvec_write_field()).

I guess the reason is that at the time of writing this code, the
CSN.1 codec was not stable enough, so it was safer to generate
the message 'by hand'.  This would also explain why we *decode*
the final RLC/MAC message in create_ul_ass() right after encoding.

Rewrite write_packet_uplink_assignment(), so now it initializes
a caller-provided 'RlcMacDownlink_t' structure.  Given that it's
allocated on heap using talloc_zero(), do not initialize presence
indicators of fields that are not present in the message.

This would facilitate handling of frequency hopping parameters
in the upcoming changes, in particular we can now introduce a
function that would compose Frequency Parameters IE for both
write_packet_{downlink,uplink}_assignment().

Tested manually by running a GPRS-enabled network, as well as by
running test cases from ttcn3-pcu-test => no regressions observed.

Change-Id: I2850b91e0043cdca8ae7498a5fc727eeedd029b6
Related: SYS#4868, OS#4547
 		2020-09-08 02:47:02 +07:00
..
osmo-bts-litecell15 direct-phy: fix handle_ph_ra_ind(): handle PH-RA.ind on PRACH SAPI 2020-08-12 18:20:33 +00:00
osmo-bts-oc2g direct-phy: fix handle_ph_ra_ind(): handle PH-RA.ind on PRACH SAPI 2020-08-12 18:20:33 +00:00
osmo-bts-sysmo direct-phy: fix handle_ph_ra_ind(): handle PH-RA.ind on PRACH SAPI 2020-08-12 18:20:33 +00:00
.gitignore Adding .gitignore to source directory 2012-06-27 17:45:15 +02:00
Makefile.am Get rid of class GprsCodingScheme 2020-05-20 11:07:07 +00:00
bts.cpp encoding: pass pdch slot directly to encoding functions 2020-08-24 10:53:08 +00:00
bts.h paging: pass struct osmo_mobile_identity, not encoded IE bytes 2020-08-24 01:12:16 +00:00
coding_scheme.c Get rid of class GprsCodingScheme 2020-05-20 11:07:07 +00:00
coding_scheme.h Get rid of class GprsCodingScheme 2020-05-20 11:07:07 +00:00
csn1.c csn1: fix csnStreamEncoder(): always check the choice index 2020-05-23 18:00:53 +07:00
csn1.h csn1: fix: never use enumerated types in codec structures 2020-05-23 19:26:58 +07:00
cxx_linuxlist.h llist: Add missing const qualifier in llist cast method 2015-08-24 12:23:50 +02:00
decoding.cpp decoding.cpp: Improve logging in malformed UL data parsing 2020-06-30 21:33:49 +02:00
decoding.h Get rid of class GprsCodingScheme 2020-05-20 11:07:07 +00:00
egprs_rlc_compression.cpp decompress_crbb: add length argument for search_runlen 2019-06-24 13:51:06 +00:00
egprs_rlc_compression.h egprs_rlc_compression: fix white spaces 2019-06-17 02:04:09 +02:00
encoding.cpp encoding: use CSN.1 codec to generate Packet Uplink Assignment 2020-09-08 02:47:02 +07:00
encoding.h encoding: use CSN.1 codec to generate Packet Uplink Assignment 2020-09-08 02:47:02 +07:00
gprs_bssgp_pcu.cpp Fix recent typo preventing MS from registering 2020-08-26 13:43:39 +02:00
gprs_bssgp_pcu.h Use clock_gettime(CLOCK_MONOTONIC) and timespec everywhere 2020-03-16 10:31:56 +00:00
gprs_codel.c Use clock_gettime(CLOCK_MONOTONIC) and timespec everywhere 2020-03-16 10:31:56 +00:00
gprs_codel.h Use clock_gettime(CLOCK_MONOTONIC) and timespec everywhere 2020-03-16 10:31:56 +00:00
gprs_debug.cpp gprs_debug: Use only LOGL_NOTICE as default loglevel 2020-05-13 16:41:55 +00:00
gprs_debug.h TBF: add dedicated log categories 2018-01-19 18:49:16 +01:00
gprs_ms.cpp Introduce log macro helper LOGPMS 2020-08-18 20:26:25 +02:00
gprs_ms.h Introduce log macro helper LOGPMS 2020-08-18 20:26:25 +02:00
gprs_ms_storage.cpp bts: Drop specific functions to add values to stats 2020-05-14 11:19:05 +00:00
gprs_ms_storage.h MS store: move test helper to unit test 2019-03-19 15:05:51 +00:00
gprs_rlcmac.cpp paging: pass struct osmo_mobile_identity, not encoded IE bytes 2020-08-24 01:12:16 +00:00
gprs_rlcmac.h pdch: rcv pkt meas rep: Allocate MS object early in path and use it 2020-08-24 07:50:49 +00:00
gprs_rlcmac_meas.cpp pdch: rcv pkt meas rep: Allocate MS object early in path and use it 2020-08-24 07:50:49 +00:00
gprs_rlcmac_sched.cpp bts: Drop specific functions to add values to counters 2020-05-14 11:19:05 +00:00
gprs_rlcmac_ts_alloc.cpp bts: Drop specific functions to increase counters 2020-05-14 11:19:05 +00:00
gsm_rlcmac.c gsm_rlcmac: use consistent naming for [Extended] Packet Timing Advance 2020-08-24 10:53:08 +00:00
gsm_rlcmac.h gsm_rlcmac: use consistent naming for [Extended] Packet Timing Advance 2020-08-24 10:53:08 +00:00
gsm_timer.cpp gsm_timer: fix comparison of constant LONG_MAX with an integer 2020-01-29 06:14:54 +07:00
gsm_timer.h pcu_l1_if: add frame number to log output 2018-04-10 13:35:24 +02:00
llc.cpp bts: Drop specific functions to increase counters 2020-05-14 11:19:05 +00:00
llc.h Use clock_gettime(CLOCK_MONOTONIC) and timespec everywhere 2020-03-16 10:31:56 +00:00
mslot_class.c mslot_class: two more: use uint32_t to shift 1 << 31 2018-03-28 14:44:47 +02:00
mslot_class.h Simplify TS alloc: move slot check into functions 2018-02-21 12:08:40 +00:00
osmobts_sock.cpp Use OSMO_FD_* instead of deprecated BSC_FD_* 2020-05-09 19:18:06 +02:00
pcu_l1_if.cpp pcu_l1_if: cosmetic: correct error message in pcu_rx_info_ind() 2020-08-24 10:53:08 +00:00
pcu_l1_if.h l1if: fix: s/pcu_rx_rach_ind_pdtch/pcu_rx_rach_ind_ptcch/g 2020-05-22 21:09:22 +07:00
pcu_main.cpp Support setting rt-prio and cpu-affinity mask through VTY 2020-08-20 08:44:54 +00:00
pcu_utils.h Use clock_gettime(CLOCK_MONOTONIC) and timespec everywhere 2020-03-16 10:31:56 +00:00
pcu_vty.c bts: add send_gsmtap_rach(), also send PTCCH/U over GSMTAP 2020-06-11 01:29:12 +07:00
pcu_vty.h Remove undefined param passed to {logging,osmo_stats}_vty_add_cmds 2019-08-05 14:30:47 +02:00
pcu_vty_functions.cpp Get rid of class GprsCodingScheme 2020-05-20 11:07:07 +00:00
pcu_vty_functions.h VTY: fix command 'show tbf all': properly filter TBFs 2019-10-09 22:00:54 +07:00
pdch.cpp pdch: rcv pkt meas rep: Allocate MS object early in path and use it 2020-08-24 07:50:49 +00:00
pdch.h paging: pass struct osmo_mobile_identity, not encoded IE bytes 2020-08-24 01:12:16 +00:00
poll_controller.cpp Move out tbf subclasses from tbf.h to their own headers 2019-09-25 17:50:06 +02:00
poll_controller.h Update header includes 2018-02-19 08:43:46 +00:00
rlc.cpp Get rid of class GprsCodingScheme 2020-05-20 11:07:07 +00:00
rlc.h Get rid of class GprsCodingScheme 2020-05-20 11:07:07 +00:00
sba.cpp bts: Drop specific functions to increase counters 2020-05-14 11:19:05 +00:00
sba.h Update header includes 2018-02-19 08:43:46 +00:00
tbf.cpp encoding: use CSN.1 codec to generate Packet Uplink Assignment 2020-09-08 02:47:02 +07:00
tbf.h tbf: Drop unneeded method set_tlli_from_ul 2020-06-26 14:35:01 +02:00
tbf.txt Doc: Update on README and tbf.txt 2012-12-18 10:04:03 +01:00
tbf_dl.cpp tbf_dl: uint8_t is enough to store a TA value 2020-07-07 17:18:14 +02:00
tbf_dl.h Get rid of class GprsCodingScheme 2020-05-20 11:07:07 +00:00
tbf_ul.cpp tbf: Drop unneeded method set_tlli_from_ul 2020-06-26 14:35:01 +02:00
tbf_ul.h tbf_ul: Fix UL ACK not sent to MS if intermediate UL block is lost 2020-05-19 09:30:23 +00:00
wireshark_compat.h Move gsm_rlcmac.cpp -> .c 2020-03-30 10:08:02 +00:00