osmo-pcu/343c0ee8d9529247001e1b49320...

74 lines
2.3 KiB
Plaintext

{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "d3e22479_0c2d5581",
"filename": "src/tbf_dl_fsm.c",
"patchSetId": 3
},
"lineNbr": 7,
"author": {
"id": 1000159
},
"writtenOn": "2022-11-20T12:27:56Z",
"side": 1,
"message": "Which license should be used? For example bts.cpp uses GNU AGPLv3+",
"revId": "343c0ee8d9529247001e1b49320831ca40591514",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "deb9f135_669bffe4",
"filename": "src/tbf_dl_fsm.c",
"patchSetId": 3
},
"lineNbr": 7,
"author": {
"id": 1000074
},
"writtenOn": "2022-11-21T10:03:43Z",
"side": 1,
"message": "The text explicitly states it: \"version 2 or [...] any later version\". So GPL2+.\n\nIn any case, I\u0027m simply splitting the code here, so I\u0027m not really changing the license here.\nSince I\u0027m the author and sysmocom holds teh copyright it can be changed to whatever we want.",
"parentUuid": "d3e22479_0c2d5581",
"revId": "343c0ee8d9529247001e1b49320831ca40591514",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "f947d01c_4e1c185a",
"filename": "src/tbf_dl_fsm.c",
"patchSetId": 3
},
"lineNbr": 182,
"author": {
"id": 1000147
},
"writtenOn": "2022-11-21T11:14:44Z",
"side": 1,
"message": "just to be sure, dispatching to the UL FSM is done on purpose here?",
"revId": "343c0ee8d9529247001e1b49320831ca40591514",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "99a7e1f4_8f12869f",
"filename": "src/tbf_dl_fsm.c",
"patchSetId": 3
},
"lineNbr": 182,
"author": {
"id": 1000074
},
"writtenOn": "2022-11-21T11:26:49Z",
"side": 1,
"message": "Yes a DL TBF can be used to assign a new UL TBF through PACCH.",
"parentUuid": "f947d01c_4e1c185a",
"revId": "343c0ee8d9529247001e1b49320831ca40591514",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}