b809866be5
tbf: Learn and propagate the TLLI changes due a new P-TMSI
...
During a routing area update a new P-TMSI was assigned. During
the PACKET CONTROL ACK on the DL we notice the change of TLLI
but didn't propagate this. This means that a Routing Area Update
Complete was only sent after a new RACH request.
Addresses:
<0007> gprs_rlcmac_meas.cpp:103 UL RSSI of TLLI=0x88661bc6: -67 dBm
<0002> bts.cpp:945 Got ACK, but UL TBF is gone TLLI=0xe512eba3
<0007> gprs_rlcmac_meas.cpp:158 DL packet loss of IMSI=274080000004765 / TLLI=0xe512eba3: 0%
<0002> tbf.cpp:668 TBF TFI=0 TLLI=0x88661bc6 T3169 timeout during transsmission
<0002> tbf.cpp:690 - Assignment was on PACCH
<0002> tbf.cpp:694 - No uplink data received yet
2013-10-30 21:24:13 +01:00
5464c9baf2
tbf: Have one imsi field and assign it through a function
...
Have one IMSI field per TBF and assign through a function call.
The IMSI should be used to look-up the TBF on the SGSN->PCU
direction.
2013-10-30 21:24:13 +01:00
34f6e5ebe6
tbf: Make tfi private and update the code
...
All logging code that used tbf->tfi is now using tbf_name to
print the the TBF. External code is now using tfi() which is
inlined and should result in the same code being generated as
before (+debug code that can be stripped).
2013-10-30 21:24:13 +01:00
474685e26e
tbf: Make the tlli "private" and update the updating code
...
Now all updates to the tlli/tlli_valid are in one place. If we
implement the policy to update the matching/linked TBF we can
now to do it in a single place. Add a todo item for that as I
am waiting for feedback from the mailinglist.
2013-10-30 21:24:13 +01:00
bd449f57a7
tbf: Create tbf_name and use it in log statements
...
This is like gsm_lchan_name and should be used in log statements.
This way we can easily change the information that is printed and
we know how to search things. The other part is that direct use
of tfi/tlli is removed which will allow us to make them private
and at the same time start to resolve the "tlli" updated in many
places.
Not old log statements are changed yet. This will done whenever
a bad log statement is seen on the console...
2013-10-30 21:24:13 +01:00
870c601f1d
tbf: TODO:Mark TLLI changes as todo item in the code
...
The TLLI can change when a new P-TMSI is assigned to the phone,
e.g. during a (periodic) routing area update. When the TLLI
changes we need to update all TBFs and maybe even register the
timing advance for the new TLLI..
2013-10-30 21:24:13 +01:00
6b88cddc21
bts: Simplify rcv_resource_request, remove logically dead code
...
tbf = find
if (tbf) {
tbf_free(tbf);
tbf = NULL;
}
if (!tbf) {
code...
}
Remove the if (!tbf) and indention as the tbf is always to be
NULL.
2013-10-30 21:24:13 +01:00
8021644e9d
bts: Kill dead stores of the tlli/tfi, fix the log message again
...
The code meant to print the tfi and not the tlli. Update it.
2013-10-30 21:24:13 +01:00
ec80f82824
tbf: Remove the trx_no field from the tbf, go through the trx object
2013-10-30 21:24:13 +01:00
fc498c9e7b
tbf: Go through the trx to get the ARFCN
2013-10-30 21:24:13 +01:00
875fc895a8
bts: Further logging improvements for TFI/TLLI output
2013-10-30 21:24:13 +01:00
e1a075ab59
bts: Pass the Packet_Control_Acknowledgement_t into the recv method
2013-10-30 21:24:13 +01:00
53a336f0e5
bts: Log the TLLI inside the report we get
2013-10-30 21:24:13 +01:00
8d0e489484
tbf: Log the TFI and TLLI so we can try to figure out more from logs
...
<0002> tbf.cpp:444 Poll timeout for DL TBF=0
<0002> tbf.cpp:513 - Timeout for polling PACKET DOWNLINK ACK.
<0002> tbf.cpp:688 - Assignment was on PACCH
<0002> tbf.cpp:694 - Downlink ACK was received
<0008> gprs_bssgp_pcu.cpp:154 LLC [SGSN -> PCU] = TLLI: 0xd6942c78 IMSI: 274080000004765 len: 506
<0002> bts.cpp:974 PACKET DOWNLINK ACK with unknown FN=2213128 TFI=0 (TRX 0 TS 6)
2013-10-30 21:24:13 +01:00
15bb1a2a51
misc: Change the logging for the tbf and what to log
...
TLLIs got printed as TBF. Fix that but also rename things to
TFI. The TFI is not required to be unique per BTS but it is
the indicator we use right now.
2013-10-30 21:24:12 +01:00
5da2014f13
bts: Use Packet_Downlink_Ack_Nack_t as parameter
2013-10-30 21:24:12 +01:00
7a344716a6
bts: Simplify the code and use Packet_Resource_Request_t*
2013-10-30 21:24:12 +01:00
cb5c49b581
bts: Work with the Packet_Measurement_Report_t
2013-10-30 21:24:12 +01:00
750ca67ce9
bts: Move the MT_PACKET_MEASUREMENT_REPORT handling to a new method
2013-10-30 21:24:12 +01:00
842808848c
bts: Move handling of MT_PACKET_RESOURCE_REQUEST to a method
...
Move the code to a new method
2013-10-30 21:24:12 +01:00
5a9658168a
bts: Move handling of MT_PACKET_DOWNLINK_ACK_NACK to separate function
...
Kill the tlli assignment as it is never used.
2013-10-30 21:24:12 +01:00
396f4161cb
pdch: Move handling of control_ack to a separate method
...
Kill the unused tfi parameter
2013-10-30 21:24:12 +01:00
c1ae22694c
bts: Count the rach frames we receive
2013-10-30 21:24:12 +01:00
90b87ea5e6
misc: Fix typo.. resource in english only has one 's'
2013-10-30 21:24:12 +01:00
180def907b
bts: Print the kind of message type not known.
2013-10-30 21:24:12 +01:00
1997787c52
llc: Count timedout and silently dropped frames
...
A DL tbf can be discarded and then the already queued LLCs will
be silently dropped. Count this event.
2013-10-30 21:24:12 +01:00
b98dd9e240
sba: Move freeing a sba into a central place
2013-10-30 21:24:12 +01:00
93e048fe27
sba: Count SBA allocation, frees and timeouts
...
Add a warning about the receive message poking in the internal
of the sba. This will be cleaned up in a follow up commit
2013-10-30 21:24:12 +01:00
158776411b
bts: Provide the first set of counters
2013-10-30 21:24:12 +01:00
f537298cca
bts: Start creating statistics inside the BTS code
2013-10-30 21:24:12 +01:00
61a0a04d26
tbf: Move gprs_rlcmac_send_data_block_acknowledged into tbf
...
We can now remove the gprs_rlcmac_data as the code has been
moved into the tbf, pdch and bts.
2013-10-30 21:24:12 +01:00
3dc56a3b34
tbf: Move gprs_rlcmac_send_packet_uplink_assignment into the tbf
2013-10-30 21:24:12 +01:00
ae03f22199
tbf: Move gprs_rlcmac_send_packet_uplink_assignment to the tbf
...
Again the function was called send but didn't do any sending
2013-10-30 21:24:12 +01:00
22b31190cb
tbf: Fix typo in thecomment
2013-10-30 21:24:12 +01:00
46bcb8d59d
tbf: Move gprs_rlcmac_send_uplink_ack into the tbf
...
The method was called send but didn't send anything. Move
it to the tbf
2013-10-30 21:24:12 +01:00
02beed5e98
bts: Move gprs_rlcmac_rcv_rach into the BTS class
2013-10-30 21:24:11 +01:00
2db7e7e7db
tbf: Move gprs_rlcmac_send_packet_downlink_assignment into the tbf
...
This method was called _send_packet_ but actually didn't do any
sending at all. It just formated the right assignment. I replaced
tbf-> with nothing.
2013-10-30 21:24:11 +01:00
24c1a5ba29
bts: Move gprs_rlcmac_trigger_downlink_assignment into BTS
2013-10-30 21:24:11 +01:00
42de18f347
debug_dl_ass_idle: Remove the feature as it is obviously broken
...
strncpy takes three arguments but only two are given. This feature
would also only work if there is one tbf at a time.
2013-10-30 21:24:11 +01:00
d9262b3b55
tbf: Move gprs_rlcmac_poll_timeout into the tbf
...
Move the gprs_rlcmac_poll_timeout method into the tbf class and
gprs_rlcmac_downlink_assignment into the BTS.
2013-10-30 21:24:11 +01:00
40cfaa6837
bts: Move rcv_imm_ass_cnf into the bts code
2013-10-30 21:24:11 +01:00
7292373f92
tbf: kill the indirection and invoke the right method
2013-10-30 21:24:11 +01:00
70ddde6929
tbf/bts: Move the tfi_find_free into the bts
2013-10-30 21:24:11 +01:00
f63cabd931
tbf/pdch/bts: Move the tbf look-up by tfi into the BTS
2013-10-30 21:24:11 +01:00
a54bbbbf02
pdch/tbf: Add another todo item for badly placed code...
2013-10-30 21:24:11 +01:00
dea63b96e0
sba/pdch: Use thepdch to look up a sba for a frame number
2013-10-30 21:24:11 +01:00
05f8efc1a2
pdch: Remove the trx_no/ts_no parameter and use/caclulate it on demand
...
Simplify the depedencies and use the inline functions when we need
to figure out the numbers.
2013-10-30 21:24:11 +01:00
4f753c64d6
pdch: Remove the bts argument from rcv_control_block
2013-10-30 21:24:11 +01:00
65be4808af
pdch: Remove the the bts parameter from rcv_data_block_acknowledged
2013-10-30 21:24:11 +01:00
6673005215
tbf: Fix typo in the debug message
2013-10-30 21:24:11 +01:00
Holger Hans Peter Freyther