From de0e558baf7016ce874299b22a525cf06524279a Mon Sep 17 00:00:00 2001
From: Philipp Maier <pmaier@sysmocom.de>
Date: Wed, 25 Mar 2020 12:23:52 +0100
Subject: [PATCH] gprs_debug: Use only LOGL_NOTICE as default loglevel

The default loglevels of some log categories are configured to
LOGL_INFO. This is still to verbose, lets use LOGL_NOTICE here.

Change-Id: Ibb1cd1a94fb4fdd0147e073f8c1c82562c2c14ef
Related: OS#2577
---
 src/gprs_debug.cpp        | 16 ++++++++--------
 tests/alloc/AllocTest.cpp |  1 +
 tests/types/TypesTest.cpp |  3 +++
 3 files changed, 12 insertions(+), 8 deletions(-)

diff --git a/src/gprs_debug.cpp b/src/gprs_debug.cpp
index 58b7e3e1..da5974b1 100644
--- a/src/gprs_debug.cpp
+++ b/src/gprs_debug.cpp
@@ -32,14 +32,14 @@ static const struct log_info_cat default_categories[] = {
 		.name = "DCSN1",
 		.color = "\033[1;31m",
 		.description = "Concrete Syntax Notation One (CSN1)",
-		.loglevel = LOGL_INFO,
+		.loglevel = LOGL_NOTICE,
 		.enabled = 0,
 	},
 	[DL1IF] = {
 		.name = "DL1IF",
 		.color = "\033[1;32m",
 		.description = "GPRS PCU L1 interface (L1IF)",
-		.loglevel = LOGL_INFO,
+		.loglevel = LOGL_NOTICE,
 		.enabled = 1,
 	},
 	[DRLCMAC] = {
@@ -81,42 +81,42 @@ static const struct log_info_cat default_categories[] = {
 		.name = "DRLCMACMEAS",
 		.color = "\033[1;31m",
 		.description = "GPRS RLC/MAC layer Measurements (RLCMAC)",
-		.loglevel = LOGL_INFO,
+		.loglevel = LOGL_NOTICE,
 		.enabled = 1,
 	},
 	[DTBF] = {
 		.name = "DTBF",
 		.color = "\033[1;34m",
 		.description = "Temporary Block Flow (TBF)",
-		.loglevel = LOGL_INFO,
+		.loglevel = LOGL_NOTICE,
 		.enabled = 1,
 	},
 	[DTBFDL] = {
 		.name = "DTBFDL",
 		.color = "\033[1;34m",
 		.description = "Temporary Block Flow (TBF) Downlink",
-		.loglevel = LOGL_INFO,
+		.loglevel = LOGL_NOTICE,
 		.enabled = 1,
 	},
 	[DTBFUL] = {
 		.name = "DTBFUL",
 		.color = "\033[1;34m",
 		.description = "Temporary Block Flow (TBF) Uplink",
-		.loglevel = LOGL_INFO,
+		.loglevel = LOGL_NOTICE,
 		.enabled = 1,
 	},
 	[DNS] = {
 		.name = "DNS",
 		.color = "\033[1;34m",
 		.description = "GPRS Network Service Protocol (NS)",
-		.loglevel = LOGL_INFO,
+		.loglevel = LOGL_NOTICE,
 		.enabled = 1,
 	},
 	[DBSSGP] = {
 		.name = "DBSSGP",
 		.color = "\033[1;34m",
 		.description = "GPRS BSS Gateway Protocol (BSSGP)",
-		.loglevel = LOGL_INFO,
+		.loglevel = LOGL_NOTICE,
 		.enabled = 1,
 	},
 	[DPCU] = {
diff --git a/tests/alloc/AllocTest.cpp b/tests/alloc/AllocTest.cpp
index fec2c31f..8ebf1594 100644
--- a/tests/alloc/AllocTest.cpp
+++ b/tests/alloc/AllocTest.cpp
@@ -809,6 +809,7 @@ int main(int argc, char **argv)
 	osmo_init_logging2(tall_pcu_ctx, &gprs_log_info);
 	log_set_use_color(osmo_stderr_target, 0);
 	log_set_print_filename(osmo_stderr_target, 0);
+	log_set_category_filter(osmo_stderr_target, DTBF, 1, LOGL_INFO);
 	if (getenv("LOGL_DEBUG"))
 		log_set_log_level(osmo_stderr_target, LOGL_DEBUG);
 
diff --git a/tests/types/TypesTest.cpp b/tests/types/TypesTest.cpp
index e3c0991d..b46a82b5 100644
--- a/tests/types/TypesTest.cpp
+++ b/tests/types/TypesTest.cpp
@@ -915,6 +915,9 @@ int main(int argc, char **argv)
 	log_set_use_color(osmo_stderr_target, 0);
 	log_set_print_filename(osmo_stderr_target, 0);
 
+	log_set_category_filter(osmo_stderr_target, DTBF, 1, LOGL_INFO);
+	log_set_category_filter(osmo_stderr_target, DTBFUL, 1, LOGL_INFO);
+
 	printf("Making some basic type testing.\n");
 
 	test_llc();