Remove undefined param passed to {logging,osmo_stats}_vty_add_cmds

Since March 15th 2017, libosmocore API logging_vty_add_cmds() had its
parameter removed (c65c5b4ea075ef6cef11fff9442ae0b15c1d6af7). However,
definition in C file doesn't contain "(void)", which means number of
parameters is undefined and thus compiler doesn't complain. Let's remove
parameters from all callers before enforcing "(void)" on it.
API osmo_stats_vty_add_cmds never had a param list but has seem problem
(no "void"), so some users decided to pass a parameter to it.

Related: OS#4138
Change-Id: Ic1ac815eafab49577ff883a5d700ecca5936d216
This commit is contained in:
Pau Espin 2019-08-05 14:30:44 +02:00
parent 2c076bcb4d
commit cd2ac56bd4
8 changed files with 10 additions and 10 deletions

View File

@ -277,7 +277,7 @@ int main(int argc, char *argv[])
bssgp_set_log_ss(DBSSGP);
vty_init(&pcu_vty_info);
pcu_vty_init(&gprs_log_info);
pcu_vty_init();
handle_options(argc, argv);
if ((!!spoof_mcc) + (!!spoof_mnc) == 1) {

View File

@ -1147,7 +1147,7 @@ struct vty_app_info pcu_vty_info = {
.is_config_node = pcu_vty_is_config_node,
};
int pcu_vty_init(const struct log_info *cat)
int pcu_vty_init(void)
{
// install_element_ve(&show_pcu_cmd);
@ -1164,8 +1164,8 @@ int pcu_vty_init(const struct log_info *cat)
NO_STR "GSMTAP Category\n",
"\n", "", 0);
logging_vty_add_cmds(cat);
osmo_stats_vty_add_cmds(cat);
logging_vty_add_cmds();
osmo_stats_vty_add_cmds();
install_node(&pcu_node, config_write_pcu);
install_element(CONFIG_NODE, &cfg_pcu_cmd);

View File

@ -12,7 +12,7 @@ enum pcu_vty_node {
int pcu_vty_go_parent(struct vty *vty);
int pcu_vty_is_config_node(struct vty *vty, int node);
int pcu_vty_init(const struct log_info *cat);
int pcu_vty_init();
extern struct vty_app_info pcu_vty_info;

View File

@ -1411,7 +1411,7 @@ int main(int argc, char **argv)
log_set_print_filename(osmo_stderr_target, 0);
vty_init(&pcu_vty_info);
pcu_vty_init(&gprs_log_info);
pcu_vty_init();
test_coding_scheme();
test_rlc_info_init();

View File

@ -121,7 +121,7 @@ int main(int argc, char **argv)
}
vty_init(&pcu_vty_info);
pcu_vty_init(&gprs_log_info);
pcu_vty_init();
current_test = 0;

View File

@ -229,7 +229,7 @@ int main(int argc, char **argv)
log_parse_category_mask(osmo_stderr_target, "DPCU,3:DLGLOBAL,1:");
vty_init(&pcu_vty_info);
pcu_vty_init(&gprs_log_info);
pcu_vty_init();
test_llc_queue();
test_llc_meta();

View File

@ -616,7 +616,7 @@ int main(int argc, char **argv)
log_parse_category_mask(osmo_stderr_target, "DPCU,3:DRLCMAC,3");
vty_init(&pcu_vty_info);
pcu_vty_init(&gprs_log_info);
pcu_vty_init();
test_ms_state();
test_ms_callback();

View File

@ -3290,7 +3290,7 @@ int main(int argc, char **argv)
"DL1IF,6:DTBF,1:DTBFUL,1:DTBFDL,1:DLGLOBAL,2:");
vty_init(&pcu_vty_info);
pcu_vty_init(&gprs_log_info);
pcu_vty_init();
test_tbf_base();
test_tbf_tlli_update();