From cc8d768fb7d038914fa51ade8b2166dcd7a89d74 Mon Sep 17 00:00:00 2001 From: Gerrit User 1000074 <1000074@035e6965-6537-41bd-912c-053f3cf69326> Date: Fri, 18 Nov 2022 15:36:46 +0000 Subject: [PATCH] Update patch set 2 Patch Set 2: (1 comment) Patch-set: 2 Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"pespin replied on the change"} Attention: {"person_ident":"Gerrit User 1000010 \u003c1000010@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"pespin replied on the change"} --- 454a60d7269278cecefad41db8c17c624661d331 | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/454a60d7269278cecefad41db8c17c624661d331 b/454a60d7269278cecefad41db8c17c624661d331 index 44491985..7dacfb5e 100644 --- a/454a60d7269278cecefad41db8c17c624661d331 +++ b/454a60d7269278cecefad41db8c17c624661d331 @@ -70,6 +70,30 @@ }, "revId": "454a60d7269278cecefad41db8c17c624661d331", "serverId": "035e6965-6537-41bd-912c-053f3cf69326" + }, + { + "unresolved": true, + "key": { + "uuid": "fcf20b82_5d57f633", + "filename": "src/tbf.h", + "patchSetId": 1 + }, + "lineNbr": 260, + "author": { + "id": 1000074 + }, + "writtenOn": "2022-11-18T15:36:46Z", + "side": 1, + "message": "It\u0027s not the \"main\" tbf, it\u0027s the \"state\" tbf as its name indicates.\n\nI can rename \"state_fsm\" as \"state_fsm_ctx\" if you want, in a separate follow-up commit.\n\nWhy allocating the context dynamically if it can be allocated as part of the tbf struct? there\u0027s no need for that.", + "parentUuid": "e6672579_6bb423ed", + "range": { + "startLine": 260, + "startChar": 23, + "endLine": 260, + "endChar": 31 + }, + "revId": "454a60d7269278cecefad41db8c17c624661d331", + "serverId": "035e6965-6537-41bd-912c-053f3cf69326" } ] } \ No newline at end of file