From bd1b90f1412a5d4b686d1a93b5ac50bdb1228b84 Mon Sep 17 00:00:00 2001 From: Pau Espin Pedrol Date: Thu, 11 Nov 2021 13:19:54 +0100 Subject: [PATCH] tbf_dl_ass_fsm: Fix missing transition to NONE if DL TBF is nonexistent If by the time the PktDlAss is to be scheduled by the scheduler the DL TBF is gone, the FSM will abort the assignment and go back to state NONE. However, the transition was missing, ending up in the scheduler trying to schedule the message unsuccessfuly lots of times per second, clogging the logs and disrupting normal operation. Related: OS#5293 Change-Id: I6f421e5ddc9894fee72de1102df35a76cf2f2647 --- src/tbf_dl_ass_fsm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/tbf_dl_ass_fsm.c b/src/tbf_dl_ass_fsm.c index efc872aa..555380df 100644 --- a/src/tbf_dl_ass_fsm.c +++ b/src/tbf_dl_ass_fsm.c @@ -208,7 +208,9 @@ static struct osmo_fsm_state tbf_dl_ass_fsm_states[] = { }, [TBF_DL_ASS_SEND_ASS] = { .in_event_mask = X(TBF_DL_ASS_EV_CREATE_RLCMAC_MSG), - .out_state_mask = X(TBF_DL_ASS_WAIT_ACK), + .out_state_mask = + X(TBF_DL_ASS_WAIT_ACK) | + X(TBF_DL_ASS_NONE), .name = "SEND_ASS", .action = st_send_ass, },