cellular-infrastructure
/
osmo-pcu
mirror of https://gerrit.osmocom.org/osmo-pcu
9
0
Fork 1
Code Issues Releases Wiki Activity

gprs_bssgp: rename gprs_ns_config -> gprs_ns_update_config 

Improve the naming of the function to match it's purpose.

Related: SYS#5354
Change-Id: Ib8e4ae734503fd6f6695d9d6767d809e1bf79d22
This commit is contained in:
Alexander Couzens 2021-02-16 16:57:15 +01:00 committed by laforge
parent 13a12e2e3b
commit 94a367f224
4 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/gprs_bssgp_pcu.c
View File

@ -1097,10 +1097,11 @@ static int ns_conf_vc_cb(struct gprs_ns2_vc *nsvc, void *ctx)
return 0;
}
int gprs_ns_config(struct gprs_rlcmac_bts *bts, uint16_t nsei,
const struct osmo_sockaddr *local,
const struct osmo_sockaddr *remote,
uint16_t *nsvci, uint16_t valid)
/* update the ns configuration if needed */
int gprs_ns_update_config(struct gprs_rlcmac_bts *bts, uint16_t nsei,
const struct osmo_sockaddr *local,
const struct osmo_sockaddr *remote,
uint16_t *nsvci, uint16_t valid)
{
int rc = 0;
if (!bts->nse) {

2
src/gprs_bssgp_pcu.h
View File

@ -90,7 +90,7 @@ struct gprs_bssgp_pcu *gprs_bssgp_init(
uint16_t mcc, uint16_t mnc, bool mnc_3_digits,
uint16_t lac, uint16_t rac, uint16_t cell_id);
int gprs_ns_config(struct gprs_rlcmac_bts *bts, uint16_t nsei,
int gprs_ns_update_config(struct gprs_rlcmac_bts *bts, uint16_t nsei,
const struct osmo_sockaddr *local,
const struct osmo_sockaddr *remote,
uint16_t *nsvci, uint16_t valid);

2
src/pcu_l1_if.cpp
View File

@ -583,7 +583,7 @@ static int pcu_info_ind_ns(struct gprs_rlcmac_bts *bts,
return -EINVAL;
}
return gprs_ns_config(bts, info_ind->nsei, local, remote, nsvci, valid);
return gprs_ns_update_config(bts, info_ind->nsei, local, remote, nsvci, valid);
}
static int pcu_rx_info_ind(struct gprs_rlcmac_bts *bts, const struct gsm_pcu_if_info_ind *info_ind)

2
tests/emu/pcu_emu.cpp
View File

@ -108,7 +108,7 @@ void create_and_connect_bssgp(struct gprs_rlcmac_bts *bts,
remote.u.sin.sin_port = htons(sgsn_port);
pcu = gprs_bssgp_init(bts, 20, 20, 901, 99, false, 1, 0, 0);
gprs_ns_config(bts, nsei, &local, &remote, &nsvci, 1);
gprs_ns_update_config(bts, nsei, &local, &remote, &nsvci, 1);
pcu->on_unblock_ack = bvci_unblocked;
pcu->on_dl_unit_data = bssgp_data;