cellular-infrastructure
/
osmo-pcu
mirror of https://gerrit.osmocom.org/osmo-pcu
9
0
Fork 1
Code Issues Releases Wiki Activity

Revert "Use Timing Advance Index in UL assignments" 

This reverts commit 6298fbb7b2,
I8b17be78a46c0bc17516b7c90f35aa4768010ae4.

Commit I52ec9b07413daabba8cd5f1fba5c7b3af6a33389 /
896574e92b was found (empirically) to be a
regression, rendering GPRS service fatally unreliable.

This reverted commit seems to follow after the regression and is reverted along
with it.

Related: OS#3013
Change-Id: I5e0fd8c9c3b89e519e7382e3d0bb24e0aeddeff6
This commit is contained in:
Neels Hofmeyr 2018-02-27 22:37:28 +01:00 committed by Harald Welte
parent f75381498c
commit 89b85e078e
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/encoding.cpp
View File

@ -255,9 +255,7 @@ static inline int write_ia_rest_uplink(const gprs_rlcmac_ul_tbf *tbf, bitvec * d
rc = write_alpha_gamma(dest, alpha, gamma);
check(rc);
rc = write_ta_index(dest, ta_idx);
check(rc);
set_0(dest); /* No TIMING_ADVANCE_INDEX */
set_0(dest); /* No TBF_STARTING_TIME */
} else {
set_0(dest); /* Single Block Allocation */
@ -319,9 +317,7 @@ static inline int write_ia_rest_egprs_uplink(const gprs_rlcmac_ul_tbf *tbf, bitv
rc = write_alpha_gamma(dest, alpha, gamma); /* ALPHA and GAMMA */
check(rc);
rc = write_ta_index(dest, ta_idx);
check(rc);
set_0(dest); /* No TIMING_ADVANCE_INDEX */
set_0(dest); /* No TBF_STARTING_TIME */
bitvec_set_bit(dest, L); /* No Additions for Rel-7 */
} else {