From 683ce64039bb9192b597e62344f0aa084b4ac4c9 Mon Sep 17 00:00:00 2001 From: Pau Espin Pedrol Date: Mon, 15 Nov 2021 14:49:08 +0100 Subject: [PATCH] T_defs_pcu: Set default val for X2000 to 0 ms That timer is really only useful to free the tbf asynchronously after generating the Pkt Access Reject message, since we have nothing to do with it after the message is sent, and the dummt TBF doesn't really hold any reserved resource such as USF or TFI. The timer is useful to still do the freeing asyncrhonously, since the scheduler is interacting with the TBF during the code path, but there's no real need to keep the object alive for 2 ms afterwards. Having a default value of 0 ms is enough, since it fullfills the requirement of freeing asnchronously. The value of 2 ms was set initially when the reject support was added here (e9a138e11111f509f988807bbdc5ca8cce2b3d3d), with no specific explanation on the 2 ms value. It was just probably picked as a convinience one, but 0 is actually more convinient. Change-Id: I60e34e643f5c9d9afaf85530c54ab3232dc8f0be --- src/gprs_pcu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gprs_pcu.c b/src/gprs_pcu.c index 8b8e46b1..76dd5be9 100644 --- a/src/gprs_pcu.c +++ b/src/gprs_pcu.c @@ -39,7 +39,7 @@ static struct osmo_tdef T_defs_pcu[] = { { .T=PCU_TDEF_SI_CACHE_ALIVE, .default_val=5, .unit=OSMO_TDEF_S, .desc="[RAC+CI]->[SI] resolution cache entry storage timeout (s)", .val=0 }, { .T=-101, .default_val=30, .unit=OSMO_TDEF_S, .desc="BSSGP (un)blocking procedures timer (s)", .val=0 }, { .T=-102, .default_val=30, .unit=OSMO_TDEF_S, .desc="BSSGP reset procedure timer (s)", .val=0 }, - { .T=-2000, .default_val=2, .unit=OSMO_TDEF_MS, .desc="Delay release of UL TBF after tx Packet Access Reject (PACCH) (ms)", .val=0 }, + { .T=-2000, .default_val=0, .unit=OSMO_TDEF_MS, .desc="Delay release of UL TBF after tx Packet Access Reject (PACCH) (ms)", .val=0 }, { .T=-2001, .default_val=2, .unit=OSMO_TDEF_S, .desc="PACCH assignment timeout (s)", .val=0 }, { .T=-2002, .default_val=200, .unit=OSMO_TDEF_MS, .desc="Waiting after IMM.ASS confirm timer (ms)", .val=0 }, { .T=-2030, .default_val=60, .unit=OSMO_TDEF_S, .desc="Time to keep an idle MS object alive (s)", .val=0 }, /* slightly above T3314 (default 44s, 24.008, 11.2.2) */