From 45143d270c9c2f1ce4e102fbb1c0456a8e39d787 Mon Sep 17 00:00:00 2001 From: Harald Welte Date: Tue, 15 May 2018 15:24:30 +0200 Subject: [PATCH] Don't register SIGHUP handler without actually handling SIGHUP In libosmocore, we normally register a SIGHUP handler for log file rotation. However, the osmo-pcu code so far installed its own signal handler, which did exactly nothing in the SIGHUP case. Let's fix this by removing SIGHUP handling here, letting libosmocore take care about this. Change-Id: Ifa20d79770bc4d88d40601b008a3a2a79d083c04 Closes: OS#3265 --- src/pcu_main.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/pcu_main.cpp b/src/pcu_main.cpp index 5b1b1be3..7480842d 100644 --- a/src/pcu_main.cpp +++ b/src/pcu_main.cpp @@ -143,7 +143,7 @@ static void handle_options(int argc, char **argv) void sighandler(int sigset) { - if (sigset == SIGHUP || sigset == SIGPIPE) + if (sigset == SIGPIPE) return; fprintf(stderr, "Signal %d received.\n", sigset); @@ -155,7 +155,6 @@ void sighandler(int sigset) * is terminated without finishing shutdown process. */ signal(SIGINT, SIG_DFL); - signal(SIGHUP, SIG_DFL); signal(SIGTERM, SIG_DFL); signal(SIGPIPE, SIG_DFL); signal(SIGABRT, SIG_DFL); @@ -311,12 +310,12 @@ int main(int argc, char *argv[]) return rc; signal(SIGINT, sighandler); - signal(SIGHUP, sighandler); signal(SIGTERM, sighandler); signal(SIGPIPE, sighandler); signal(SIGABRT, sighandler); signal(SIGUSR1, sighandler); signal(SIGUSR2, sighandler); + osmo_init_ignore_signals(); /* enable realtime priority for us */ if (rt_prio != -1) {