cellular-infrastructure
/
osmo-pcu
mirror of https://gerrit.osmocom.org/osmo-pcu
9
0
Fork 1
Code Issues Releases Wiki Activity

Don't register SIGHUP handler without actually handling SIGHUP 

In libosmocore, we normally register a SIGHUP handler for log file
rotation.

However, the osmo-pcu code so far installed its own signal handler,
which did exactly nothing in the SIGHUP case.

Let's fix this by removing SIGHUP handling here, letting libosmocore
take care about this.

Change-Id: Ifa20d79770bc4d88d40601b008a3a2a79d083c04
Closes: OS#3265
This commit is contained in:
Harald Welte 2018-05-15 15:24:30 +02:00
parent f1a334be63
commit 45143d270c
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/pcu_main.cpp
View File

@ -143,7 +143,7 @@ static void handle_options(int argc, char **argv)
void sighandler(int sigset)
{
if (sigset == SIGHUP || sigset == SIGPIPE)
if (sigset == SIGPIPE)
return;
fprintf(stderr, "Signal %d received.\n", sigset);
@ -155,7 +155,6 @@ void sighandler(int sigset)
* is terminated without finishing shutdown process.
*/
signal(SIGINT, SIG_DFL);
signal(SIGHUP, SIG_DFL);
signal(SIGTERM, SIG_DFL);
signal(SIGPIPE, SIG_DFL);
signal(SIGABRT, SIG_DFL);
@ -311,12 +310,12 @@ int main(int argc, char *argv[])
return rc;
signal(SIGINT, sighandler);
signal(SIGHUP, sighandler);
signal(SIGTERM, sighandler);
signal(SIGPIPE, sighandler);
signal(SIGABRT, sighandler);
signal(SIGUSR1, sighandler);
signal(SIGUSR2, sighandler);
osmo_init_ignore_signals();
/* enable realtime priority for us */
if (rt_prio != -1) {