cellular-infrastructure
/
osmo-pcu
mirror of https://gerrit.osmocom.org/osmo-pcu
9
0
Fork 1
Code Issues Releases Wiki Activity

pcu_l1_if: Check pag_req id_lv len fits buffer 

Related: OS#4316
Change-Id: I803e1d2577a0d210e74feb5ca4c216375a5024ea
This commit is contained in:
Pau Espin 2019-12-09 13:55:12 +01:00
parent 30f6617c79
commit 32499b614b
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/pcu_l1_if.cpp
View File

@ -19,6 +19,7 @@
#include <stdio.h>
#include <unistd.h>
#include <inttypes.h>
#include <stdlib.h>
#include <string.h>
#include <errno.h>
@ -636,6 +637,13 @@ static int pcu_rx_pag_req(struct gsm_pcu_if_pag_req *pag_req)
LOGP(DL1IF, LOGL_DEBUG, "Paging request received: chan_needed=%d "
"length=%d\n", pag_req->chan_needed, pag_req->identity_lv[0]);
/* check if identity does not fit: length > sizeof(lv) - 1 */
if (pag_req->identity_lv[0] >= sizeof(pag_req->identity_lv)) {
LOGP(DL1IF, LOGL_ERROR, "Paging identity too large (%" PRIu8 ")\n",
pag_req->identity_lv[0]);
return -EINVAL;
}
return BTS::main_bts()->add_paging(pag_req->chan_needed,
pag_req->identity_lv);
}