From 02fbfc15c7678cb02a19b4c2f01f9efc80756d14 Mon Sep 17 00:00:00 2001 From: Max Date: Wed, 13 Mar 2019 15:55:54 +0100 Subject: [PATCH] Fix TA index encoder MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The TAI is described as { 0 | 1 < TIMING_ADVANCE_INDEX : bit (4) > } in 3GPP TS 44.018 ยง10.5.2.16.1 so it should be encoded with if-else. Change-Id: I54482790e1cf3cb13a635a99a481250576deabaf --- src/encoding.cpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/encoding.cpp b/src/encoding.cpp index ad53b0bd..e21a7fcf 100644 --- a/src/encoding.cpp +++ b/src/encoding.cpp @@ -117,13 +117,13 @@ static int write_ta_index(bitvec *dest, int8_t tai) { int rc; - if (tai < 0) /* No TIMING_ADVANCE_INDEX: */ + if (tai < 0) { /* No TIMING_ADVANCE_INDEX: */ SET_0(dest); - - /* TIMING_ADVANCE_INDEX: */ - SET_1(dest); - rc = bitvec_set_u64(dest, tai, 4, false); - CHECK(rc); + } else { /* TIMING_ADVANCE_INDEX: */ + SET_1(dest); + rc = bitvec_set_u64(dest, tai, 4, false); + CHECK(rc); + } return 0; }