osmo-msc/8b6f08c78704efaa13aec701626...

249 lines
8.1 KiB
Plaintext

{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "0f4c540b_64b8ea6a",
"filename": "/COMMIT_MSG",
"patchSetId": 28
},
"lineNbr": 7,
"author": {
"id": 1000005
},
"writtenOn": "2022-09-15T11:43:07Z",
"side": 1,
"message": "would be good to give a reason for the move / which other caller is currently expected",
"revId": "8b6f08c78704efaa13aec7016263cc554629af35",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "ae9590ca_0473d3d3",
"filename": "/COMMIT_MSG",
"patchSetId": 28
},
"lineNbr": 7,
"author": {
"id": 1000159
},
"writtenOn": "2022-09-27T05:55:37Z",
"side": 1,
"message": "Done",
"parentUuid": "0f4c540b_64b8ea6a",
"revId": "8b6f08c78704efaa13aec7016263cc554629af35",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "eea16e45_c127e0bc",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 28
},
"lineNbr": 0,
"author": {
"id": 1000147
},
"writtenOn": "2022-09-15T09:00:25Z",
"side": 1,
"message": "FYI you can just override the jenkins linter error if it doesn\u0027t make sense (remove the -1 build verification vote from jenkins and add your own +1 build verification).\n\nWe should probably disable the check for MACRO_WITH_FLOW_CONTROL? -\u003e https://gerrit.osmocom.org/c/osmo-ci/+/29359",
"revId": "8b6f08c78704efaa13aec7016263cc554629af35",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "61edffe2_2c5cb9ae",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 28
},
"lineNbr": 0,
"author": {
"id": 1000159
},
"writtenOn": "2022-09-15T09:42:43Z",
"side": 1,
"message": "I also dislike flow control macro but in this case it doesn\u0027t make sense indeed.",
"parentUuid": "eea16e45_c127e0bc",
"revId": "8b6f08c78704efaa13aec7016263cc554629af35",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "d0e995e0_d7829698",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 28
},
"lineNbr": 0,
"author": {
"id": 1000159
},
"writtenOn": "2022-09-15T09:43:41Z",
"side": 1,
"message": "Seems like I can\u0027t remove jenkins vote: the trash icon is only visible next to my own vote.",
"parentUuid": "61edffe2_2c5cb9ae",
"revId": "8b6f08c78704efaa13aec7016263cc554629af35",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "dcbf9993_b50aaa3a",
"filename": "include/osmocom/smpp/smpp.h",
"patchSetId": 28
},
"lineNbr": 51,
"author": {
"id": 1000005
},
"writtenOn": "2022-09-15T11:43:07Z",
"side": 1,
"message": "you have diff \u0027+\u0027 leaked into the C code",
"revId": "8b6f08c78704efaa13aec7016263cc554629af35",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "99471e7b_11b17d10",
"filename": "include/osmocom/smpp/smpp.h",
"patchSetId": 28
},
"lineNbr": 51,
"author": {
"id": 1000159
},
"writtenOn": "2022-09-27T05:55:37Z",
"side": 1,
"message": "Done",
"parentUuid": "dcbf9993_b50aaa3a",
"revId": "8b6f08c78704efaa13aec7016263cc554629af35",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "683ef905_fe48acca",
"filename": "include/osmocom/smpp/smpp.h",
"patchSetId": 28
},
"lineNbr": 53,
"author": {
"id": 1000005
},
"writtenOn": "2022-09-15T11:43:07Z",
"side": 1,
"message": "I would prefer to keep this macro confined locally to a .c file, i guess smpp_utils.c\n\n- contains flow control (not local to a .c file but in a header file)\n- requiring a label\n- requiring a specific return type in calling code\n\nIf this makes it into public API, it needs a more detailed explanation,\nparticularly about the \u0027return 0\u0027 meaning \"try again\". I guess best would be a code example of what the macro expects.",
"revId": "8b6f08c78704efaa13aec7016263cc554629af35",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "ba12ec78_4e4c538c",
"filename": "include/osmocom/smpp/smpp.h",
"patchSetId": 28
},
"lineNbr": 53,
"author": {
"id": 1000159
},
"writtenOn": "2022-09-27T05:55:37Z",
"side": 1,
"message": "Done",
"parentUuid": "683ef905_fe48acca",
"revId": "8b6f08c78704efaa13aec7016263cc554629af35",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "95e06b96_0280d326",
"filename": "include/osmocom/smpp/smpp.h",
"patchSetId": 28
},
"lineNbr": 55,
"author": {
"id": 1000005
},
"writtenOn": "2022-09-15T11:43:07Z",
"side": 1,
"message": "hmm idk.\n\nthis should have a name that is different from the general libosmocore-style to avoid naming conflicts.\nFor example if you plan to move it to libosmocore, then you can clearly switch from one to the other. like SMPP_CHECK_FD_READ",
"revId": "8b6f08c78704efaa13aec7016263cc554629af35",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "820325a5_a2a32abb",
"filename": "include/osmocom/smpp/smpp.h",
"patchSetId": 28
},
"lineNbr": 55,
"author": {
"id": 1000159
},
"writtenOn": "2022-09-27T05:55:37Z",
"side": 1,
"message": "I\u0027m also not convinced this is worth moving to libosmocore - I don\u0027t think macro with flow control is a good idea in general. But that\u0027s the comment in the comment in the original code - I\u0027ve simply kept it in place while moving it. I also keep the name intact for the same reason.",
"parentUuid": "95e06b96_0280d326",
"revId": "8b6f08c78704efaa13aec7016263cc554629af35",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "75c3dae7_8579125f",
"filename": "src/libsmpputil/smpp_utils.c",
"patchSetId": 28
},
"lineNbr": 58,
"author": {
"id": 1000005
},
"writtenOn": "2022-09-15T11:43:07Z",
"side": 1,
"message": "drop \\brief, see https://osmocom.org/projects/cellular-infrastructure/wiki/Guidelines_for_API_documentation#Summary",
"revId": "8b6f08c78704efaa13aec7016263cc554629af35",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "816b746f_6f579534",
"filename": "src/libsmpputil/smpp_utils.c",
"patchSetId": 28
},
"lineNbr": 58,
"author": {
"id": 1000159
},
"writtenOn": "2022-09-27T05:55:37Z",
"side": 1,
"message": "Done",
"parentUuid": "75c3dae7_8579125f",
"revId": "8b6f08c78704efaa13aec7016263cc554629af35",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "8448af0d_bece25b5",
"filename": "src/libsmpputil/smpp_utils.c",
"patchSetId": 28
},
"lineNbr": 117,
"author": {
"id": 1000005
},
"writtenOn": "2022-09-15T11:43:07Z",
"side": 1,
"message": "documentation for args and rc?\n(I tried to understand the \u0027exit(99)\u0027 below and found no explanation for rc \u003d\u003d 0)",
"revId": "8b6f08c78704efaa13aec7016263cc554629af35",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}