osmo-msc/tests
Neels Hofmeyr 986fe7ed18 store classmark in vlr_subscr, not conn
Store all Classmark information in the VLR.

So, we now always know the Classmark 1 (mandatory IE for LU). This is visible
in the msc_vlr_tests -- they no longer indicate "assuming A5/1 is supported"
because classmark 1 is missing, because we now know the Classmark 1.

Rationale:

During Location Updating, we receive Classmark 1; during CM Service Request and
Paging Response, we receive Classmark 2. So far we stored these only for the
duration of the conn, so as soon as a LU is complete, we would forget CM1.

In other words, for anything else than a LU Request, we had no Classmark 1
available at all.

During Ciphering Mode Command, we rely on Classmark 1 to determine whether A5/1
is supported. That is moot if we don't even have a Classmark 1 for any CM
Service Request or Paging Response initiated connections.

The only reason that A5/1 worked is that we assume A5/1 to work if Classmark 1
is missing. To add to the confusion, if a phone indicated that it did *not*
support A5/1 in the Classmark 1, according to spec we're supposed to not
service it at all. A code comment however says that we instead want to heed the
flag -- which so far was only present in a Location Updating initiated
connection. Now we can make this decision without assuming things.

This got my attention while hacking on sending a BSSMAP Classmark Request from
the MSC if it finds missing Classmark information, and was surprised to see it
it lacking CM1 to decide about A5/1.

Change-Id: I27081bf6e9e017923b2d02607f7ea06beddad82a
2018-09-17 01:12:13 +02:00
..
db remove empty libcommon-cs 2018-03-22 17:11:30 +01:00
msc_vlr store classmark in vlr_subscr, not conn 2018-09-17 01:12:13 +02:00
smpp use osmo_init_logging2() with proper talloc ctx 2018-03-30 23:20:03 +02:00
sms_queue Remove local libgsupclient; Use libosmo-gsup-client from osmo-hlr 2018-08-05 11:20:21 +02:00
Makefile.am split off osmo-msc: remove files, apply build, rename 2017-08-29 12:51:19 +00:00
atlocal.in remove further files and autotest/autoconf bits irrelevant to osmo-msc 2017-10-03 09:44:23 +08:00
ctrl_test_runner.py Remove unneeded .py scripts 2017-12-03 21:14:10 +00:00
smpp_test_runner.py Implement IuCS (large refactoring and addition) 2017-08-08 19:17:53 +02:00
testsuite.at msc_vlr_tests: don't abuse USSD-request to conclude connections 2018-07-29 16:22:06 +02:00
vty_test_runner.py remove unused "auth policy" VTY command 2018-02-14 09:04:56 +01:00