osmo-msc/include/osmocom/msc
Neels Hofmeyr 33f534136c cosmetic: vlr: rename auth_tuple_max_use_count to _reuse_
The name auth_tuple_max_use_count suggests that if I want to use each auth
tuple exactly once, I need to set it to 1. Curiously, so far you need to set
to intended uses - 1.

Reflect this in its name by renaming to auth_tuple_max_reuse_count.

I first considered to not rename but change the if-conditions so that == 1
means each tuple is used once, and upon struct vlr allocation, set the default
to 1. That would also logically entail that setting to 0 means to re-use
vectors infinitely often, like now a value < 0 does. That means, when
allocating a vlr struct zeroed out, we would by default have the most
dangerous/unsafe configuration. It's no problem to set a default to 1 upon
allocation, but by renaming the variable instead, we get safer alloc-zero
behavior and don't need to change any conditionals in the code (even though the
patch ends up considerably larger from all the renaming).

Change-Id: I0b036cae1536d5d6fb2304f837ed1a6c3713be55
2017-10-31 02:02:43 +01:00
..
Makefile.am Remove pkg-config file 2017-10-16 15:29:26 +02:00
a_iface.h Remove rest_octets.h 2017-09-15 11:31:03 +02:00
a_iface_bssap.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
a_reset.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
abis_nm.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
abis_om2000.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
abis_rsl.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
arfcn_range_encode.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
auth.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
bsc_api.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
bsc_msc.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
bsc_msc_data.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
bsc_msg_filter.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
bsc_rll.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
chan_alloc.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
common.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
common_bsc.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
common_cs.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
crc24.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
ctrl.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
db.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
debug.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
e1_config.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
gsm_04_08.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
gsm_04_11.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
gsm_04_14.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
gsm_04_80.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
gsm_data.h Remove BTS-specific attributes 2017-09-15 14:15:52 +02:00
gsm_data_shared.h Remove BTS-specific attributes 2017-09-15 14:15:52 +02:00
gsm_subscriber.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
gsup_client.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
handover.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
handover_decision.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
ipaccess.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
iu_dummy.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
iucs.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
iucs_ranap.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
meas_feed.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
meas_rep.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
misdn.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
mncc.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
mncc_int.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
msc_ifaces.h Remove rest_octets.h 2017-09-15 11:31:03 +02:00
network_listen.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
oap_client.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
openbscdefines.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
osmo_bsc.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
osmo_bsc_grace.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
osmo_bsc_reset.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
osmo_bsc_sigtran.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
osmo_msc.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
osmux.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
paging.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
rrlp.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
rs232.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
rtp_proxy.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
signal.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
silent_call.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
slhc.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
smpp.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
sms_queue.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
socket.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
system_information.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
transaction.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
trau_mux.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
trau_upqueue.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
ussd.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00
vlr.h cosmetic: vlr: rename auth_tuple_max_use_count to _reuse_ 2017-10-31 02:02:43 +01:00
vty.h rename include/openbsc to include/osmocom/msc 2017-09-06 16:41:25 +02:00