39 lines
1.3 KiB
Plaintext
39 lines
1.3 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "3f3ba062_f4b67149",
|
|
"filename": "src/libmsc/sdp_msg.c",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 271,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2022-11-14T10:49:14Z",
|
|
"side": 1,
|
|
"message": "Isn\u0027t sdp_audio_codec_is_set() implemented by checking codec-\u003esubtype_name[0] like before? what\u0027s changing in this patch? I\u0027m missing something?",
|
|
"revId": "1d19fe3c7afd701e78a3364deef764abef14a64e",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "4309fc95_0ff23a4f",
|
|
"filename": "src/libmsc/sdp_msg.c",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 271,
|
|
"author": {
|
|
"id": 1000004
|
|
},
|
|
"writtenOn": "2022-11-14T19:38:10Z",
|
|
"side": 1,
|
|
"message": "the previous code did not check if codec-\u003esubtype was a valid pointer at all, and unconditionally dereferenced it. The new code is now checkign for a valid pointer, and whether the first character is non-NUL.",
|
|
"parentUuid": "3f3ba062_f4b67149",
|
|
"revId": "1d19fe3c7afd701e78a3364deef764abef14a64e",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
}
|
|
]
|
|
} |