Osmocom Mobile Switching Centre
Go to file
Jacob Erlbeck 7ffa7b095f nitb: Fix IMSI/IMEI buffer handling (Coverity)
Currently the handling of the buffers is not done consistently. Some
code assumes that the whole buffer may be used to store the string
while at other places, the last buffer byte is left untouched in the
assumption that it contains a terminating NUL-character. The latter
is the correct behaviour.

This commit changes to code to not touch the last byte in the buffers
and to rely on the last byte being NUL. So the maximum IMSI/IMEI
length is GSM_IMSI_LENGTH-1/GSM_IMEI_LENGTH-1.

For information: We assume that we allocate the structure with
talloc_zero. This means we have NULed the entire imsi array and then
only write sizeof - 1 characters to it. So the last byte remains NUL.

Fixes: Coverity CID 1206568, 1206567
Sponsored-by: On-Waves ehf
2015-04-10 08:47:00 +02:00
debian debian: We are at version 0.14 now 2015-03-14 20:33:43 +01:00
hlrsync hlrsync: Sync SMS from the web db to the hlr. 2009-08-14 21:33:34 +02:00
linux-kernel new kernel patch for multiple virtual interfaces 2009-08-10 23:36:53 +02:00
openbsc nitb: Fix IMSI/IMEI buffer handling (Coverity) 2015-04-10 08:47:00 +02:00
wireshark Fix bogus message labelling in wireshark OML dissector 2011-09-19 09:19:09 +02:00
.gitignore ignore debian build byproducts 2015-03-28 17:13:57 +01:00
README first commit 2011-02-05 20:26:25 +01:00

README