cellular-infrastructure
/
osmo-msc
mirror of https://gerrit.osmocom.org/osmo-msc
9
0
Fork 0
Code Issues Releases Wiki Activity
osmo-msc/openbsc/src
History
Neels Hofmeyr 2afffd5cf6 Revert "bts: extend bts_chan_load to allow counting tch only" 
This reverts commit 308cb0719d.

Problems in this commit:

openbsc/src/libbsc/chan_alloc.c:523:   case GSM_PCHAN_TCH_F_PDCH:
This is actually wrong, GSM_PCHAN_TCH_F_PDCH use ts->flags, not ts->dyn below
(due to historical reasons and could be unified).

560:   if (only_count_tch && !chan_is_tch(ts))
This has exactly one effect: it excludes GSM_PCHAN_TCH_F_PDCH when in PDCH
mode, because for all other PDCH (plain PDCH and TCH/F_TCH/H_PDCH in PDCH mode)
below ts_subslots() returns 0 and skips the for() loop. I consider this a bug
in TCH/F_PDCH, to be fixed in an upcoming commit.

I don't see why we need the only_count_tch argument, because this should
normally only count TCH, weren't it for the TCH/F_PDCH bug.

If dyn TS should be counted differently, we should do this in a different way.

Change-Id: I34dbbaf53a800115e3d03bd44028cad675f3b525
 		2016-09-28 00:28:01 +00:00
..
gprs log VTY telnet bind only once 2016-09-27 05:00:18 +00:00
ipaccess mscsplit: gsm_network_init(): add explicit root talloc ctx 2016-09-26 02:25:46 +02:00
libbsc Revert "bts: extend bts_chan_load to allow counting tch only" 2016-09-28 00:28:01 +00:00
libcommon mscsplit: talloc_ctx_init(): decouple from global tall_bsc_ctx 2016-09-26 02:25:46 +02:00
libfilter Consistenly format variables in */Makefile.am files 2016-09-15 15:55:02 +02:00
libiu Consistenly format variables in */Makefile.am files 2016-09-15 15:55:02 +02:00
libmgcp Consistenly format variables in */Makefile.am files 2016-09-15 15:55:02 +02:00
libmsc mscsplit: directly access gsm_network backpointer from gsm_subscriber_connection 2016-09-26 02:25:46 +02:00
libtrau Consistenly format variables in */Makefile.am files 2016-09-15 15:55:02 +02:00
osmo-bsc mscsplit: bsc_vty_init(): decouple from global bsc_gsmnet 2016-09-26 02:25:46 +02:00
osmo-bsc_mgcp log VTY telnet bind only once 2016-09-27 05:00:18 +00:00
osmo-bsc_nat log VTY telnet bind only once 2016-09-27 05:00:18 +00:00
osmo-nitb mscsplit: bsc_vty_init(): decouple from global bsc_gsmnet 2016-09-26 02:25:46 +02:00
utils mscsplit: gsm_network_init(): add explicit root talloc ctx 2016-09-26 02:25:46 +02:00
Makefile.am Consistenly format variables in */Makefile.am files 2016-09-15 15:55:02 +02:00