cellular-infrastructure
/
osmo-msc
mirror of https://gerrit.osmocom.org/osmo-msc
9
0
Fork 0
Code Issues Releases Wiki Activity

sms_queue: Print dest msisdn instead of unknown subscriber 

If subscriber is NULL, vlr_subscr_msisdn_or_name() returns string
"unknown", which is less informative than printing destination msisdn
expected for the queued sms.
This happens for instance if an sms was queued with Store&Forward and
destination subscriber is not currently registered

Change-Id: I4b8b54c9c41b17d4e1fa7ece63aa91a98036ef11
This commit is contained in:
Pau Espin 2019-04-09 12:44:35 +02:00 committed by Vadim Yanitskiy
parent 0f52319765
commit f8af776fba
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/libmsc/sms_queue.c
View File

@ -228,8 +228,10 @@ struct gsm_sms *smsq_take_next_sms(struct gsm_network *net,
/* Is the subscriber attached? If not, go to next SMS */
if (!sms->receiver || !sms->receiver->lu_complete) {
LOGP(DLSMS, LOGL_DEBUG,
"Subscriber %s is not attached, skipping SMS %llu\n",
vlr_subscr_msisdn_or_name(sms->receiver), sms->id);
"Subscriber %s%s is not attached, skipping SMS %llu\n",
sms->receiver ? "" : "MSISDN-",
sms->receiver ? vlr_subscr_msisdn_or_name(sms->receiver)
: sms->dst.addr, sms->id);
sms_free(sms);
continue;
}