cellular-infrastructure
/
osmo-msc
mirror of https://gerrit.osmocom.org/osmo-msc
9
0
Fork 0
Code Issues Releases Wiki Activity

libsmpputil: fix -Wtautological-constant-out-of-range-compare 

* 'sizeof(sms->user_data)' evaluates to 256
* 'ud_len' is of type 'uint8_t' and cannot be greater than 256

Change-Id: Ia71a0b6b9421911dc5113782d2f555a640fd90ed
This commit is contained in:
Vadim Yanitskiy 2024-02-14 18:20:26 +07:00 committed by fixeria
parent d851b2c029
commit f09832a395
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/libsmpputil/smpp_msc.c
View File

@ -241,7 +241,7 @@ static int submit_to_sms(struct gsm_sms **psms, struct gsm_network *net,
}
if (mode == MODE_7BIT) {
uint8_t ud_len = 0, padbits = 0;
unsigned int ud_len = 0, padbits = 0;
sms->data_coding_scheme = GSM338_DCS_1111_7BIT;
if (sms->ud_hdr_ind) {
ud_len = *sms_msg + 1;