Update patch set 1
Patch Set 1: Code-Review+1 (4 comments) Patch-set: 1 Reviewer: Gerrit User 1000074 <1000074@035e6965-6537-41bd-912c-053f3cf69326> Label: Code-Review=+1 Attention: {"person_ident":"Gerrit User 1000005 \u003c1000005@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"pespin replied on the change"}
This commit is contained in:
parent
c9c3106967
commit
e06abbbfbc
|
@ -0,0 +1,72 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "f7d25854_c420e439",
|
||||
"filename": "include/osmocom/msc/codec_filter.h",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 49,
|
||||
"author": {
|
||||
"id": 1000074
|
||||
},
|
||||
"writtenOn": "2022-11-14T10:39:57Z",
|
||||
"side": 1,
|
||||
"message": "At first glance it looks a bit strange why you are mixing the RTP port here with the codec resolution. What\u0027s the rationale behind doing it here together?",
|
||||
"revId": "b83ec2d0135b054c82b4310b201965c02241b168",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "d77199e8_7e9147e0",
|
||||
"filename": "src/libmsc/codec_filter.c",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 8,
|
||||
"author": {
|
||||
"id": 1000074
|
||||
},
|
||||
"writtenOn": "2022-11-14T10:39:57Z",
|
||||
"side": 1,
|
||||
"message": "no AGPL?",
|
||||
"revId": "b83ec2d0135b054c82b4310b201965c02241b168",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "6e1cd713_de0f5efc",
|
||||
"filename": "src/libmsc/codec_filter.c",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 28,
|
||||
"author": {
|
||||
"id": 1000074
|
||||
},
|
||||
"writtenOn": "2022-11-14T10:39:57Z",
|
||||
"side": 1,
|
||||
"message": "why is this called \"mobile_codecs\" but the one below is \"utran_codecs\"? Call this oen geran_codecs?",
|
||||
"revId": "b83ec2d0135b054c82b4310b201965c02241b168",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "d55ca8e3_dc324698",
|
||||
"filename": "src/libmsc/codec_filter.c",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 124,
|
||||
"author": {
|
||||
"id": 1000074
|
||||
},
|
||||
"writtenOn": "2022-11-14T10:39:57Z",
|
||||
"side": 1,
|
||||
"message": "Does this mean osmo-msc currently doesn\u0027t support it but it could support it?",
|
||||
"revId": "b83ec2d0135b054c82b4310b201965c02241b168",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue