cellular-infrastructure
/
osmo-msc
mirror of https://gerrit.osmocom.org/osmo-msc
9
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 49 

Patch Set 49:

(3 comments)

Patch-set: 49
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"Max replied on the change"}
Attention: {"person_ident":"Gerrit User 1000159 \u003c1000159@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"Max replied on the change"}
This commit is contained in:
Gerrit User 1000159 2022-10-27 14:36:06 +00:00 committed by Gerrit Code Review
parent 98225b51eb
commit db9791a119
2 changed files with 54 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
7d7fc04e8126aab46d6b5ab63e618f93d775b128
View File

@ -17,6 +17,24 @@
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "3fa9e4c2_f44d41de",
"filename": "src/libsmpputil/smpp_msc.c",
"patchSetId": 49
},
"lineNbr": 847,
"author": {
"id": 1000159
},
"writtenOn": "2022-10-27T14:36:06Z",
"side": 1,
"message": "Hmm.. yepp, it can be dropped.",
"parentUuid": "7ebe887b_ad124956",
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@ -68,6 +86,24 @@
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "bd987a53_ba352839",
"filename": "src/libsmpputil/smpp_smsc.c",
"patchSetId": 49
},
"lineNbr": 760,
"author": {
"id": 1000159
},
"writtenOn": "2022-10-27T14:36:06Z",
"side": 1,
"message": "I think it\u0027s better to use the type which matches exactly the size from SMPP spec - 4 bytes.",
"parentUuid": "b572a5a8_fa3652fe",
"revId": "7d7fc04e8126aab46d6b5ab63e618f93d775b128",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {

18
bb624162ead2524ef4e1c72358a329ab1f2a9406
View File

@ -16,6 +16,24 @@
"message": "Nice bug here setting to null before calling put on it. Better submit a patch preior to this one just fixing this.",
"revId": "bb624162ead2524ef4e1c72358a329ab1f2a9406",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "6b0e2d42_9448e55f",
"filename": "src/libsmpputil/smpp_smsc.c",
"patchSetId": 49
},
"lineNbr": 166,
"author": {
"id": 1000159
},
"writtenOn": "2022-10-27T14:36:06Z",
"side": 0,
"message": "Ack",
"parentUuid": "17cecaf8_e7993d7b",
"revId": "bb624162ead2524ef4e1c72358a329ab1f2a9406",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}