Clear Command: set cause value to "Call Control"

So far, by failing to initialize the cause value, we always send a Clear
Command cause == 0, which actually means "Radio Interface Message Failure".
This is seen in all my logged network traces of osmo-msc lab testing.

"Call Control" seems to be the only cause value that remotely fits a normal
release procedure, even if it was not voice call related, see 3GPP TS 48.008
3.2.1.21.

Related: OS#4664
Change-Id: I1347ed72ae7d7ea73a557b866e764819c5ef8c42
This commit is contained in:
Neels Hofmeyr 2020-07-11 00:20:20 +02:00
parent 458fe3d789
commit d9fe7110ea
1 changed files with 3 additions and 0 deletions

View File

@ -779,6 +779,9 @@ static void msc_a_fsm_releasing_onenter(struct osmo_fsm_inst *fi, uint32_t prev_
struct ran_msg msg = {
.msg_type = RAN_MSG_CLEAR_COMMAND,
.clear_command = {
/* "Call Control" is the only cause code listed in 3GPP TS 48.008 3.2.1.21 CLEAR COMMAND
* that qualifies for a normal release situation. (OS#4664) */
.gsm0808_cause = GSM0808_CAUSE_CALL_CONTROL,
.csfb_ind = (vsub && vsub->sgs_fsm->state == SGS_UE_ST_ASSOCIATED),
},
};