From cc7db18e1a5bd8d9dd19cf5179caefc6eb8841de Mon Sep 17 00:00:00 2001 From: Neels Hofmeyr Date: Sun, 18 Dec 2016 23:52:38 +0100 Subject: [PATCH] various comment / whitespace tweaks (libmsc, gprs, libcommon-cs) cosmetic ws in common_cs_vty.c, osmo_msc.c comment: tiny typo fix in gsm_04_08.c In comments, drop some unbalanced braces, because simplistic C file harvesters will break at a single opening brace even if it is in a comment. This is aimed at the fsm-to-dot.py script in libosmocore/contrib. Change-Id: I3c1fa53195a1e57d6fe0a6791c346d30ceff1251 --- openbsc/src/gprs/gprs_sndcp.c | 1 + openbsc/src/gprs/gtphub.c | 2 +- openbsc/src/libcommon-cs/common_cs_vty.c | 2 +- openbsc/src/libmsc/gsm_04_08.c | 2 +- openbsc/src/libmsc/osmo_msc.c | 2 +- 5 files changed, 5 insertions(+), 4 deletions(-) diff --git a/openbsc/src/gprs/gprs_sndcp.c b/openbsc/src/gprs/gprs_sndcp.c index 60455b518..a18998f9e 100644 --- a/openbsc/src/gprs/gprs_sndcp.c +++ b/openbsc/src/gprs/gprs_sndcp.c @@ -911,6 +911,7 @@ static int sndcp_rx_llc_prim() case LL_DATA_CONF: case LL_UNITDATA_IND: case LL_STATUS_IND: + } } #endif diff --git a/openbsc/src/gprs/gtphub.c b/openbsc/src/gprs/gtphub.c index 83e17dbd4..a1aaed213 100644 --- a/openbsc/src/gprs/gtphub.c +++ b/openbsc/src/gprs/gtphub.c @@ -553,7 +553,7 @@ static void gtp_decode(const uint8_t *data, int data_len, } #if 1 - /* TODO if () { ... + /* TODO if () (waiting for a commit from jerlbeck) */ int i; diff --git a/openbsc/src/libcommon-cs/common_cs_vty.c b/openbsc/src/libcommon-cs/common_cs_vty.c index 7f8b49581..08a758151 100644 --- a/openbsc/src/libcommon-cs/common_cs_vty.c +++ b/openbsc/src/libcommon-cs/common_cs_vty.c @@ -163,7 +163,7 @@ DEFUN(cfg_net_encryption, { struct gsm_network *gsmnet = gsmnet_from_vty(vty); - gsmnet->a5_encryption= atoi(argv[0]); + gsmnet->a5_encryption = atoi(argv[0]); return CMD_SUCCESS; } diff --git a/openbsc/src/libmsc/gsm_04_08.c b/openbsc/src/libmsc/gsm_04_08.c index 742f803d4..1e2575492 100644 --- a/openbsc/src/libmsc/gsm_04_08.c +++ b/openbsc/src/libmsc/gsm_04_08.c @@ -3759,7 +3759,7 @@ int gsm0408_dispatch(struct gsm_subscriber_connection *conn, struct msgb *msg) } /* - * This will be ran by the linker when loading the DSO. We use it to + * This will be run by the linker when loading the DSO. We use it to * do system initialization, e.g. registration of signal handlers. */ static __attribute__((constructor)) void on_dso_load_0408(void) diff --git a/openbsc/src/libmsc/osmo_msc.c b/openbsc/src/libmsc/osmo_msc.c index 12a5117fa..2389980d3 100644 --- a/openbsc/src/libmsc/osmo_msc.c +++ b/openbsc/src/libmsc/osmo_msc.c @@ -131,7 +131,7 @@ static void msc_ciph_m_compl(struct gsm_subscriber_connection *conn, static struct bsc_api msc_handler = { .sapi_n_reject = msc_sapi_n_reject, .compl_l3 = msc_compl_l3, - .dtap = msc_dtap, + .dtap = msc_dtap, .clear_request = msc_clear_request, .assign_compl = msc_assign_compl, .assign_fail = msc_assign_fail,