From c02b12086c365ed473e034b3363f1cf4ce5226c1 Mon Sep 17 00:00:00 2001 From: Holger Hans Peter Freyther Date: Tue, 28 Dec 2010 22:26:34 +0100 Subject: [PATCH] subscr: Fix subscr leaks in the KI code. --- openbsc/src/vty_interface_layer3.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/openbsc/src/vty_interface_layer3.c b/openbsc/src/vty_interface_layer3.c index e04d9f57d..844ad3fc1 100644 --- a/openbsc/src/vty_interface_layer3.c +++ b/openbsc/src/vty_interface_layer3.c @@ -540,18 +540,23 @@ DEFUN(ena_subscr_a3a8, minlen = maxlen = A38_COMP128_KEY_LEN; } else { /* Unknown method */ + subscr_put(subscr); return CMD_WARNING; } if (ki_str) { rc = hexparse(ki_str, ainfo.a3a8_ki, sizeof(ainfo.a3a8_ki)); - if ((rc > maxlen) || (rc < minlen)) + if ((rc > maxlen) || (rc < minlen)) { + subscr_put(subscr); return CMD_WARNING; + } ainfo.a3a8_ki_len = rc; } else { ainfo.a3a8_ki_len = 0; - if (minlen) + if (minlen) { + subscr_put(subscr); return CMD_WARNING; + } } rc = db_sync_authinfo_for_subscr( @@ -560,6 +565,7 @@ DEFUN(ena_subscr_a3a8, /* the last tuple probably invalid with the new auth settings */ db_sync_lastauthtuple_for_subscr(NULL, subscr); + subscr_put(subscr); return rc ? CMD_WARNING : CMD_SUCCESS; }