From b46ee1eb8459ae107b254a3f6f963a4004f86f94 Mon Sep 17 00:00:00 2001
From: Gerrit User 1000005 <1000005@035e6965-6537-41bd-912c-053f3cf69326>
Date: Thu, 15 Sep 2022 11:43:07 +0000
Subject: [PATCH] Update patch set 28

Patch Set 28:

(6 comments)

Patch-set: 28
CC: Gerrit User 1000005 <1000005@035e6965-6537-41bd-912c-053f3cf69326>
Attention: {"person_ident":"Gerrit User 1000159 \u003c1000159@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"neels replied on the change"}
---
 8b6f08c78704efaa13aec7016263cc554629af35 | 102 +++++++++++++++++++++++
 1 file changed, 102 insertions(+)

diff --git a/8b6f08c78704efaa13aec7016263cc554629af35 b/8b6f08c78704efaa13aec7016263cc554629af35
index 62374a679..77f88cc06 100644
--- a/8b6f08c78704efaa13aec7016263cc554629af35
+++ b/8b6f08c78704efaa13aec7016263cc554629af35
@@ -1,5 +1,22 @@
 {
   "comments": [
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "0f4c540b_64b8ea6a",
+        "filename": "/COMMIT_MSG",
+        "patchSetId": 28
+      },
+      "lineNbr": 7,
+      "author": {
+        "id": 1000005
+      },
+      "writtenOn": "2022-09-15T11:43:07Z",
+      "side": 1,
+      "message": "would be good to give a reason for the move / which other caller is currently expected",
+      "revId": "8b6f08c78704efaa13aec7016263cc554629af35",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
     {
       "unresolved": false,
       "key": {
@@ -52,6 +69,91 @@
       "parentUuid": "61edffe2_2c5cb9ae",
       "revId": "8b6f08c78704efaa13aec7016263cc554629af35",
       "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "dcbf9993_b50aaa3a",
+        "filename": "include/osmocom/smpp/smpp.h",
+        "patchSetId": 28
+      },
+      "lineNbr": 51,
+      "author": {
+        "id": 1000005
+      },
+      "writtenOn": "2022-09-15T11:43:07Z",
+      "side": 1,
+      "message": "you have diff \u0027+\u0027 leaked into the C code",
+      "revId": "8b6f08c78704efaa13aec7016263cc554629af35",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "683ef905_fe48acca",
+        "filename": "include/osmocom/smpp/smpp.h",
+        "patchSetId": 28
+      },
+      "lineNbr": 53,
+      "author": {
+        "id": 1000005
+      },
+      "writtenOn": "2022-09-15T11:43:07Z",
+      "side": 1,
+      "message": "I would prefer to keep this macro confined locally to a .c file, i guess smpp_utils.c\n\n- contains flow control (not local to a .c file but in a header file)\n- requiring a label\n- requiring a specific return type in calling code\n\nIf this makes it into public API, it needs a more detailed explanation,\nparticularly about the \u0027return 0\u0027 meaning \"try again\". I guess best would be a code example of what the macro expects.",
+      "revId": "8b6f08c78704efaa13aec7016263cc554629af35",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "95e06b96_0280d326",
+        "filename": "include/osmocom/smpp/smpp.h",
+        "patchSetId": 28
+      },
+      "lineNbr": 55,
+      "author": {
+        "id": 1000005
+      },
+      "writtenOn": "2022-09-15T11:43:07Z",
+      "side": 1,
+      "message": "hmm idk.\n\nthis should have a name that is different from the general libosmocore-style to avoid naming conflicts.\nFor example if you plan to move it to libosmocore, then you can clearly switch from one to the other. like SMPP_CHECK_FD_READ",
+      "revId": "8b6f08c78704efaa13aec7016263cc554629af35",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "75c3dae7_8579125f",
+        "filename": "src/libsmpputil/smpp_utils.c",
+        "patchSetId": 28
+      },
+      "lineNbr": 58,
+      "author": {
+        "id": 1000005
+      },
+      "writtenOn": "2022-09-15T11:43:07Z",
+      "side": 1,
+      "message": "drop \\brief, see https://osmocom.org/projects/cellular-infrastructure/wiki/Guidelines_for_API_documentation#Summary",
+      "revId": "8b6f08c78704efaa13aec7016263cc554629af35",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "8448af0d_bece25b5",
+        "filename": "src/libsmpputil/smpp_utils.c",
+        "patchSetId": 28
+      },
+      "lineNbr": 117,
+      "author": {
+        "id": 1000005
+      },
+      "writtenOn": "2022-09-15T11:43:07Z",
+      "side": 1,
+      "message": "documentation for args and rc?\n(I tried to understand the \u0027exit(99)\u0027 below and found no explanation for rc \u003d\u003d 0)",
+      "revId": "8b6f08c78704efaa13aec7016263cc554629af35",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
     }
   ]
 }
\ No newline at end of file