cellular-infrastructure
/
osmo-msc
mirror of https://gerrit.osmocom.org/osmo-msc
9
0
Fork 0
Code Issues Releases Wiki Activity

mncc: Fix a crash in the call release code 

When the remote subscriber has not responded yet we could
end up with a crash in the MNCC code. It was enough to dial
the number, then hang up and bsc_hack would end up with a
segfault due the list poisining of linux_list.
This commit is contained in:
Holger Hans Peter Freyther 2011-01-27 15:05:45 +01:00
parent 6e94d6d10d
commit a61c709ef0
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
openbsc/src/mncc_builtin.c
View File

@ -238,12 +238,18 @@ static int mncc_rel_ind(struct gsm_call *call, int msg_type, struct gsm_mncc *re
free_call(call);
return 0;
}
rel->callref = remote->callref;
DEBUGP(DMNCC, "(call %x) Releasing remote with cause %d\n",
call->callref, rel->cause.value);
mncc_tx_to_cc(remote->net, MNCC_REL_REQ, rel);
/*
* Release this side of the call right now. Otherwise we end up
* in this method for the other call and will also try to release
* it and then we will end up with a double free and a crash
*/
free_call(call);
mncc_tx_to_cc(remote->net, MNCC_REL_REQ, rel);
return 0;
}