cellular-infrastructure
/
osmo-msc
mirror of https://gerrit.osmocom.org/osmo-msc
9
0
Fork 0
Code Issues Releases Wiki Activity

vlr_subscr_rx_id_resp(): dont assert on received MI type 

The Mobile Identity type is received on the wire, we asserting on its type
constitutes a DoS vector.

Change-Id: I2b2e25ef8e878e91a165018ba49f1609cfb5cbd0
This commit is contained in:
Neels Hofmeyr 2020-06-02 22:02:01 +02:00 committed by neels
parent 346a3b956f
commit a40adf78c3
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/libvlr/vlr.c
View File

@ -1146,6 +1146,8 @@ int vlr_subscr_rx_id_resp(struct vlr_subscr *vsub,
case GSM_MI_TYPE_IMEISV: case GSM_MI_TYPE_IMEISV:
vlr_subscr_set_imeisv(vsub, mi_string); vlr_subscr_set_imeisv(vsub, mi_string);
break; break;
default:
return -EINVAL;
} }
if (vsub->auth_fsm) { if (vsub->auth_fsm) {
@ -1170,8 +1172,7 @@ int vlr_subscr_rx_id_resp(struct vlr_subscr *vsub,
event = VLR_ULA_E_ID_IMEISV; event = VLR_ULA_E_ID_IMEISV;
break; break;
default: default:
OSMO_ASSERT(0); return -EINVAL;
break;
} }
osmo_fsm_inst_dispatch(vsub->lu_fsm, event, mi_string); osmo_fsm_inst_dispatch(vsub->lu_fsm, event, mi_string);
} }