cellular-infrastructure
/
osmo-msc
mirror of https://gerrit.osmocom.org/osmo-msc
9
0
Fork 0
Code Issues Releases Wiki Activity

libmsc/db: avoid subscr->name without terminating NULL char 

Change-Id: Ic8944ac4c5e940c9d835c52f1701461f274238db
Fixes: Coverity CID 57621
This commit is contained in:
Harald Welte 2016-11-25 23:57:01 +01:00
parent b0993e61d0
commit 96df077083
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
openbsc/src/libmsc/db.c
View File

@ -831,8 +831,10 @@ static void db_set_from_query(struct gsm_subscriber *subscr, dbi_conn result)
subscr->tmsi = tmsi_from_string(string);
string = dbi_result_get_string(result, "name");
if (string)
if (string) {
strncpy(subscr->name, string, GSM_NAME_LENGTH);
subscr->name[sizeof(subscr->name)-1] = '\0';
}
string = dbi_result_get_string(result, "extension");
if (string)