cellular-infrastructure
/
osmo-msc
mirror of https://gerrit.osmocom.org/osmo-msc
9
0
Fork 0
Code Issues Releases Wiki Activity

libmsc/gsm_09_11.c: drop meaningless check for concurrent paging 

This check was copy-pasted from the CC handling code during the
initial development of "SS/USSD over GSUP" feature. It probably
makes sense for MT calls, but definitely not for SS/USSD.

Change-Id: I2899a23ee49fd7917443943629603700a5025cf4
This commit is contained in:
Vadim Yanitskiy 2019-06-15 16:56:20 +07:00
parent ae95436c7a
commit 95b040c45a
1 changed files with 1 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/libmsc/gsm_09_11.c
View File

@ -314,7 +314,7 @@ static struct gsm_trans *establish_nc_ss_trans(struct gsm_network *net,
struct vlr_subscr *vsub, const struct osmo_gsup_message *gsup_msg)
{
struct msc_a *msc_a;
struct gsm_trans *trans, *transt;
struct gsm_trans *trans;
int tid;
if (gsup_msg->session_state != OSMO_GSUP_SESSION_STATE_BEGIN) {
@ -363,20 +363,6 @@ static struct gsm_trans *establish_nc_ss_trans(struct gsm_network *net,
LOG_TRANS(trans, LOGL_DEBUG, "Triggering Paging Request\n");
/* Find transaction with this subscriber already paging */
llist_for_each_entry(transt, &net->trans_list, entry) {
/* Transaction of our conn? */
if (transt == trans || transt->vsub != vsub)
continue;
LOG_TRANS(trans, LOGL_ERROR, "Paging already started, "
"rejecting message...\n");
trans_free(trans);
/* FIXME: WTF IS THIS!? This is completely insane. Presence of a trans doesn't indicate Paging, and even
* if, why drop the current request??? */
return NULL;
}
/* Trigger Paging Request */
trans->paging_request = paging_request_start(vsub, PAGING_CAUSE_SIGNALLING_HIGH_PRIO,
ss_paging_cb, trans, "GSM 09.11 SS/USSD");