cellular-infrastructure
/
osmo-msc
mirror of https://gerrit.osmocom.org/osmo-msc
9
0
Fork 0
Code Issues Releases Wiki Activity

gsm_04_11_gsup.c: drop unused conn lookup 

An earlier code state used the conn to lookup the transaction, but this is now
done by vsub. Hence the conn lookup is not used and not needed.

conn is no longer used since 36c44b2100,
change-Id I093f36d63e671e50e54fc6236e97a777cc6da77b,
"transaction: change arguments of trans_find_by_sm_rp_mr()"

Change-Id: Ia878d70138c883cb1a1d983516aff83efa6488ce
This commit is contained in:
Neels Hofmeyr 2019-03-07 03:43:46 +01:00
parent 8e2c6a31c1
commit 864d32c043
1 changed files with 0 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/libmsc/gsm_04_11_gsup.c
View File

@ -121,7 +121,6 @@ int gsm411_gsup_mo_handler(struct vlr_subscr *vsub,
struct vlr_instance *vlr;
struct gsm_network *net;
struct gsm_trans *trans;
struct ran_conn *conn;
const char *msg_name;
bool msg_is_err;
@ -165,16 +164,6 @@ int gsm411_gsup_mo_handler(struct vlr_subscr *vsub,
if (msg_is_err && !gsup_msg->sm_rp_cause)
goto msg_error;
/* Attempt to find a DTAP-connection */
conn = connection_for_subscr(vsub);
if (!conn) {
/* FIXME: should we establish it then? */
LOGP(DLSMS, LOGL_NOTICE, "No connection found for %s, "
"ignoring %s-%s message...\n", vlr_subscr_name(vsub),
msg_name, msg_is_err ? "Err" : "Res");
return -EIO; /* TODO: notify sender about that? */
}
/* Attempt to find DTAP-transaction */
trans = trans_find_by_sm_rp_mr(net, vsub, *(gsup_msg->sm_rp_mr));
if (!trans) {